Replace angular.fromJson with JSON.parse

[BatJan]

Prerequisites

Fixing this issue https://trello.com/c/uPQwJmDQ/9-replace-instances-of-angularfromjson

If there's an existing issue for this PR then this fixes

Description

I have been replacing all instances of angular.fromJson with JSON.parse. 😃

[nul800sebastiaan]

Thanks! 👍

[bjarnef]

It seems this is causing issues now, when inserting e.g. image grid editor in grid content.

Umbraco-CMS/src/Umbraco.Web.UI.Client/src/common/services/util.service.js

Line 209 in a5ff8a4

return JSON.parse(storage["umb_" + key]);

where angular.fromJson() is a bit different:
https://github.com/angular/angular.js/blob/master/src/Angular.js#L1335-L1339

With angular.fromJson() I can open the image dialog:

with just the current change using JSON.Parse():

It seems to be an empty when session storage is empty, where JSON.Parse throw an error.

[nul800sebastiaan]

@bjarnef Hmmm.. Maybe it's the same issue as #8013 though? And not so much an issue with this change?

[bjarnef]

@nul800sebastiaan not sure if the issue @lars-erik is having is the same since it is in v8.6.x ...
anyway I am working on a PR regarding the issue, when inserting an image grid editor in grid content:
#8014

[lars-erik]

@nul800sebastiaan @bjarnef This is not related to #8013, but makes it so you can't even get to #8013. 😆
I didn't notice since I copied the change to the controller into built output in a soon-to-be-prod-ready 8.6.1 site, so didn't get the services update that blocks it. Now doing more work for a possible second PR based on the contrib branch where I merged #8014 and about to test more.