Fix regression from valpropertymsg directive changes #7690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression where validation object doesn't always exist on the property, depending on context - when adding an editor to a content type, the validation logic runs, but the validation property on the editor doesn't exist.
Changes here add an explicit check for
currentProperty.validation
before trying to access.mandatory
This relates to the changes from #7662 - ping @poornimanayar since she's across those changes 😄
Prerequisites
To test, edit a content type, adding a new property editor, should be no JS errors logged into the console. Validation should clear as expected when editing the property value on a content item.