v8: 7647 Can't save content after clearing property with validation error #7662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @nathanwoulfe ! We shall review the work and get back to you if we need anything more. Regards, |
|
Useful bits are down around line 142 - rest is mainly whitespace/line-length stuff. |
|
I am sure I have seen this during my v7 training days, so well done on getting this fixed. On it now! |
poornimanayar
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
@nathanwoulfe , this totally works and happy to approve it! Thanks for your work as always!
|
And merged :-) ⭐️ Thanks for the work once again |
|
No worries at all! Was a tricky one to track down :) |
1 task
nul800sebastiaan
added
release/8.7.0
release/no-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #7647
Description
This was due to validation not checking for an empty value, which is a valid state for non-mandatory fields.
Changes here ensure that when we set the validation state on a property form, we check that the property is not mandatory and has no value - if both those flags are true, existing errors are cleared and form controls all reset.
I'm not really across the intricacies of the client-side validation, but from what I can see, the changes fix the problem, and don't impact on existing validation logic. Needs a good sanity check though from someone saner than I.
I've tested by reproducing the scenario from the original bug report. All works as expected - saving with an invalid value displays the validation messages, clearing the value clears the validation.