Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8: Accessibility Create User Page Title #7104

Merged
merged 7 commits into from
May 26, 2020
Merged

v8: Accessibility Create User Page Title #7104

merged 7 commits into from
May 26, 2020

Conversation

RachBreeze
Copy link
Contributor

This PR sets the page title when creating a user, it extends #7102

Rachel Breeze and others added 2 commits November 7, 2019 15:01
@emmaburstow
Copy link
Contributor

😄

@RachBreeze RachBreeze mentioned this pull request Dec 17, 2019
Merged
@RachBreeze
Copy link
Contributor Author

Hi, I'd like to look to finish of the title work I've been doing and would be good to get feedback on this PR please, there's a few places in the CMS where as a developer we can't just set the title and screen reader properties properties containing the name are loaded after the header is loaded, and ng-hide won't resolve this issue. This works alongside #7102 in an attempt to resolve this issue

@RachBreeze
Copy link
Contributor Author

Hiya
Have you managed to review this yet please? Is there anything I can do to assist? As mentioned above I've got a few more tbd issues which would be dependent on this PR so it would be great to get feedback.

@poornimanayar
Copy link
Contributor

Hi @RachBreeze ,

Apologies for delayed response. Can you fix the merge conflict here? I can look at it for you then :-)

Poornima

Merge branch 'v8/dev' of https://github.com/RachBreeze/Umbraco-CMS in…
39668c1 
…to v8/temp-pagetitle-createuser

# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js
@RachBreeze
Copy link
Contributor Author

Hi @poornimanayar
I have fixed the merge conflict thank you
Rachel

@poornimanayar poornimanayar changed the base branch from v8/dev to v8/contrib April 26, 2020 10:42
@nul800sebastiaan
Merge branch 'v8/contrib' into pr/7104
9111bc4 
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js
#	src/Umbraco.Web.UI.Client/src/views/users/user.controller.js
@nul800sebastiaan
Revert a v7 change that sneaked in
4ada65e
@nul800sebastiaan
Whitepace
9a9c51c
@nul800sebastiaan
Whitepace
06cc9c4
@nul800sebastiaan nul800sebastiaan merged commit e260410 into umbraco:v8/contrib May 26, 2020
@nul800sebastiaan
Copy link
Member

Thanks, this works like a charm :-)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/accessibility community/pr release/8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RachBreeze @emmaburstow @poornimanayar @nul800sebastiaan