Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8: Accessibility Changes For umbEditorHeader Directive (edit user) #7102

Merged
merged 5 commits into from
May 26, 2020
Merged

V8: Accessibility Changes For umbEditorHeader Directive (edit user) #7102

merged 5 commits into from
May 26, 2020

Conversation

RachBreeze
Copy link
Contributor

This PR extends #6315 by adding the $setAccessibleHeader event to enable the umbHeader Directive to set the screen reader properties and setting the page title when a user edits an existing user.

Rachel Breeze and others added 2 commits November 7, 2019 15:01
Added support for $setAccessibleHeader which can be used to set acces…
83203ef 
…sibility on the umb editor header control when there is no editorState.Current
@emmaburstow
Merge branch 'v8/dev' into pr/7102
e28116f
@RachBreeze RachBreeze mentioned this pull request Nov 7, 2019
Merged
@emmaburstow
Copy link
Contributor

Hey Rachel,

Thanks for the work here :) We'll shout if we need you.

Em

@RachBreeze
Copy link
Contributor Author

Hi
I've got a couple of changes I'd like to make based on this PR and on #7104 it would be lovely to get some feedback please
Thank you in advance

@RachBreeze
Copy link
Contributor Author

Hi, I'd like to look to finish of the title work I've been doing and would be good to get feedback on this PR please, there's a few places in the CMS where as a developer we can't just set the title and screen reader properties properties containing the name are loaded after the header is loaded, and ng-hide won't resolve this issue. $setAccessibleHeader attempts to resolve this by allowing them to be set after the header directive is loaded.

@RachBreeze
Copy link
Contributor Author

Hiya
Have you managed to review this yet please? Is there anything I can do to assist? As mentioned above I've got a few more tbd issues which would be dependent on this PR so it would be great to get feedback.

@nul800sebastiaan
Merge branch 'v8/contrib' into pr/7102
d8c336a 
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/components/editor/umbeditorheader.directive.js
#	src/Umbraco.Web.UI.Client/src/views/users/user.controller.js
@nul800sebastiaan nul800sebastiaan changed the base branch from v8/dev to v8/contrib May 26, 2020 08:54
@nul800sebastiaan
Copy link
Member

Hi @RachBreeze and sorry for the long delay! I've merged this with the latest v8/contrib so it's up to date. I'm a bit confused about this change here to the loader that seems unrelated, why is that one changed please?

https://github.com/umbraco/Umbraco-CMS/pull/7102/files#diff-cc14314b8965974db240d069e00e28d0R2-R3

@nul800sebastiaan
Copy link
Member

Turns out that change came from v7 like with some of your other PRs, so I've reverted that for now.

Looks good otherwise! 👍

@nul800sebastiaan nul800sebastiaan merged commit 5541d13 into umbraco:v8/contrib May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category/accessibility community/pr release/8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RachBreeze @emmaburstow @nul800sebastiaan