Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: Moved the accessibility texts into visuallyHidden #6978

Merged
merged 3 commits into from
Jan 14, 2020
Merged

v8: Moved the accessibility texts into visuallyHidden #6978

merged 3 commits into from
Jan 14, 2020

Conversation

RachBreeze
Copy link
Contributor

This PR moves the accessibility texts created in #6315 and #5760 into the visuallyHidden section, following @BatJan conventions

…hidden section to comply with other commits
@poornimanayar
Copy link
Contributor

Thanks yet again @RachBreeze !

@RachBreeze
Copy link
Contributor Author

Hi
I guess the merge conflicts are blocking this? Would you like me to review them?
Thank you in advance
Rachel

@poornimanayar
Copy link
Contributor

Hi @RachBreeze ,

Apologies for the delay in review. We are still ploughing through the backlog. Yes, if you can fix the merge conflicts I will get it reviewed for you :-)

Poornima

…to v8/visually-hidden

# Conflicts:
#	src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
#	src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
@RachBreeze
Copy link
Contributor Author

Hi @poornimanayar
No worries, thank you for getting back so quick :-)
I've taken a look at and merged the two conflicting language files. If there's anything else I can do to help please let me know
Cheers

@poornimanayar
Copy link
Contributor

Hi @RachBreeze ,

Can you add some notes on how I can test this?

Poornima

@RachBreeze
Copy link
Contributor Author

Hi @poornimanayar

Happy New Year! So sorry for the slow reply, Christmas and illness got in the way.

I moved a number of translations from the placeholders section in the language files to the visuallyHiddenTexts section.

As part of the move I've renamed 3 of the items as follows as part of the move:

  • a11yCreateItem is now createItem
  • a11yEdit is now edit
  • a11yName is now name

In terms of testing the texts are hidden visually, and show on a screen reader when tabing through the header directive, for example when the user is editing content as shown below
image

This change impacts the umbeditorcontentheader directive and the umbeditorheader directive. It can't be seen visually, only be a screen reader users, for example when editing content the screen reader says "Name edit required"
And when creating a new content item the screen reader user hears "xxx name edit required"
Where xxxx is the name of the content item being created

This PR doesn't change any existing functionality, it just ensures that the naming conventions introduced by @BatJan are followed

I hope this helps

Rachel

@RachBreeze RachBreeze changed the title Moved the accessibility texts into visuallyHidden v8: Moved the accessibility texts into visuallyHidden Jan 3, 2020
@kjac kjac changed the base branch from v8/dev to v8/contrib January 14, 2020 19:33
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RachBreeze this works perfectly 👍 thank you for taking your time to ensure some consistency!

@kjac kjac merged commit d841fdc into umbraco:v8/contrib Jan 14, 2020
@kjac
Copy link
Contributor

kjac commented Jan 14, 2020

Merged 😄

@RachBreeze
Copy link
Contributor Author

@kjac you're welcome and thank you too

@nul800sebastiaan nul800sebastiaan removed the release/no-notes This is too small to add to the release notes or fixed after a beta/RC label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants