-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8: Moved the accessibility texts into visuallyHidden #6978
Conversation
…hidden section to comply with other commits
Thanks yet again @RachBreeze ! |
Hi |
Hi @RachBreeze , Apologies for the delay in review. We are still ploughing through the backlog. Yes, if you can fix the merge conflicts I will get it reviewed for you :-) Poornima |
…to v8/visually-hidden # Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/en.xml # src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
Hi @poornimanayar |
Hi @RachBreeze , Can you add some notes on how I can test this? Poornima |
Happy New Year! So sorry for the slow reply, Christmas and illness got in the way. I moved a number of translations from the placeholders section in the language files to the visuallyHiddenTexts section. As part of the move I've renamed 3 of the items as follows as part of the move:
In terms of testing the texts are hidden visually, and show on a screen reader when tabing through the header directive, for example when the user is editing content as shown below This change impacts the umbeditorcontentheader directive and the umbeditorheader directive. It can't be seen visually, only be a screen reader users, for example when editing content the screen reader says "Name edit required" This PR doesn't change any existing functionality, it just ensures that the naming conventions introduced by @BatJan are followed I hope this helps Rachel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RachBreeze this works perfectly 👍 thank you for taking your time to ensure some consistency!
Merged 😄 |
@kjac you're welcome and thank you too |
This PR moves the accessibility texts created in #6315 and #5760 into the visuallyHidden section, following @BatJan conventions