Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Accessibility improvements for page name entry #5760

Merged
merged 5 commits into from
Aug 9, 2019
Merged

V8: Accessibility improvements for page name entry #5760

merged 5 commits into from
Aug 9, 2019

Conversation

RachBreeze
Copy link
Contributor

This PR is a resubmission of #5585

It aims to fix 43, 69, 75, 81 from the from the A & AA accessibility issue list #5277

Creating a content item
When creating a new content type there is screen reader only text which says:
"Create" + content type name

The concept is that it wkors as per Microsoft Teams, here when a user creates a folder they see:

image

Editing a content item
When editing an existing content item there is screen reader only text which says
"Edit" + content name

Name label
The "name" text box also now now has a hidden label which is "content type name" + Name

Placeholder
The placeholder in the name textbox remains the same as prior to this change, as placeholder text provides guidance for many users, placeholder text is not a replacement for labels.

Language amends
The language files now have accessibility specific place holders these have been added to en.xml and en_us.xml only

Rachel Breeze added 3 commits July 1, 2019 20:41
…hey are creating new content, what they are creating it for, and if they are editing content what page they are editing it on
@emmaburstow
Copy link
Contributor

Hi Rachel,

Thanks ever so much for the work. We'll take a look and let you know if we need anything from you.

Emma

@nul800sebastiaan
Copy link
Member

Hey @RachBreeze! Thanks very much for the help here, I'll test it soon.

Just as a heads up: I have reverted most of your changes in the language files since it was impossible to figure out what actually changed. In the future, try to see in your git client, before you commit changes if all the whitespace has changed. It would be good to only commit the few lines that have actually changed so that the diff is readable. 👍

@nul800sebastiaan nul800sebastiaan merged commit ab3202b into umbraco:v8/dev Aug 9, 2019
@nul800sebastiaan
Copy link
Member

Works great! 🔉 "Edit Home" and 🔉 "Create ContentPage" - cool stuff!

Thanks very much @RachBreeze - well done! 👍👍

@nul800sebastiaan
Copy link
Member

Cherry picked into 8.1.3 (9cab789)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants