V8: Accessibility Changes For Title On Content Section #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lovely, thanks a lot! |
This was referenced Sep 9, 2019
nul800sebastiaan
added a commit
that referenced
this pull request
Sep 26, 2019
…t name on each change of the language dropdown
rasmusjp
pushed a commit
that referenced
this pull request
Sep 26, 2019
…t name on each change of the language dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the page title when the user is in the content section and builds on the work in #5888
The aim is to help screen reader users and also content editors which have multiple tabs open determine what they are doing in the content section.
The logic for the title being set is in umbeditorcontentheader.directive.js as opposed to init.js to prevent multiple hits on the database to retrieve the content name/ content type being edited.