Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Accessibility Changes For Title On Login Page #5888

Merged
merged 1 commit into from
Sep 5, 2019
Merged

V8: Accessibility Changes For Title On Login Page #5888

merged 1 commit into from
Sep 5, 2019

Conversation

RachBreeze
Copy link
Contributor

@RachBreeze RachBreeze commented Jul 14, 2019

This PR aims to give the user more context as to what the page is displaying by setting the <title> element

I have made this a draft PR because whilst is solves the issue on the login page, it isn't generic enough.

Ideally a SetTitle method based on this init.js routine should be created:

$rootScope.$on('$routeChangeSuccess', function (event, current, previous) {..}

Currently it relies on a .params property which doesn't exist in the context of the login page.

A refactored "SetTitle" routine could then be reused once logged into Umbraco to provide more context as to what action the user is performing (currently on the section the user is in is displayed in the title, not what area within that section/ or if the user is creating/ editing something). More information would help:

  • screen reader uses have context as to what the page is for
  • all users who in 2 or more browsers with the same Umbraco site open

@emmaburstow
Copy link
Contributor

Hi Rachel,

Thanks for this work. I can see it's still got Draft as its status. We'll take a look once it's complete.

Emma

@RachBreeze RachBreeze marked this pull request as ready for review August 29, 2019 18:08
@RachBreeze
Copy link
Contributor Author

Hey so have spent a while looking at making a generic SetTitle routine and failed. Feel it would be good to get this as a PR and revisit the generic routine again

@nul800sebastiaan
Copy link
Member

Lovely @RachBreeze - thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants