V8: Accessibility Changes For Title On Login Page #5888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to give the user more context as to what the page is displaying by setting the
<title>
elementI have made this a draft PR because whilst is solves the issue on the login page, it isn't generic enough.
Ideally a
SetTitle
method based on thisinit.js
routine should be created:$rootScope.$on('$routeChangeSuccess', function (event, current, previous) {..}
Currently it relies on a
.params
property which doesn't exist in the context of the login page.A refactored "
SetTitle
" routine could then be reused once logged into Umbraco to provide more context as to what action the user is performing (currently on the section the user is in is displayed in the title, not what area within that section/ or if the user is creating/ editing something). More information would help: