Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Open User Details - Back icon arrow is identified as "Umbraco link" #5970

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Accessibility: Open User Details - Back icon arrow is identified as "Umbraco link" #5970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
096ed5e
Change <a> to <button> and fix the styling accordingly and add a sr-o…
BatJan Jul 22, 2019
212da92
Merge branch 'v8/dev' into pr/5970
nul800sebastiaan Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Umbraco.Web.UI.Client/src/less/components/editor.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,11 @@
}

.umb-editor-header__back {
color: @gray-6;
margin-bottom: 1px;
background: transparent;
border: 0;
color: @gray-6;
margin: 0 0 1px 0;
padding: 0;
transition: color 0.1s ease-in-out;
}

Expand Down
5 changes: 3 additions & 2 deletions src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-content-header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
<div class="flex items-center" style="height: 100%;">

<div ng-if="showBackButton === true && splitViewOpen !== true" style="margin-right: 15px;">
<a class="umb-editor-header__back" href="#" ng-click="goBack()" prevent-default>
<button type="button" class="umb-editor-header__back" ng-click="goBack()" prevent-default>
<i class="fa fa-arrow-left" aria-hidden="true"></i>
</a>
<span class="sr-only"><localize key="visuallyHiddenTexts_goBack">Go back</localize></span>
</button>
</div>

<div class="flex items-center" style="flex: 1;">
Expand Down
5 changes: 3 additions & 2 deletions src/Umbraco.Web.UI.Client/src/views/components/editor/umb-editor-header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
<div class="flex items-center" style="height: 100%;">

<div ng-if="showBackButton === true && splitViewOpen !== true" style="margin-right: 15px;">
<a class="umb-editor-header__back" href="#" ng-click="goBack()" prevent-default>
<button type="button" class="umb-editor-header__back" ng-click="goBack()" prevent-default>
<i class="fa fa-arrow-left" aria-hidden="true"></i>
</a>
<span class="sr-only"><localize key="visuallyHiddenTexts_goBack">Go back</localize></span>
</button>
</div>

<div class="flex items-center" style="flex: 1;">
Expand Down
3 changes: 3 additions & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/da.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,4 +1610,7 @@ Mange hilsner fra Umbraco robotten
<key alias="memberIntro">Kom godt i gang</key>
<key alias="formsInstall">Installer Umbraco Forms</key>
</area>
<area alias="visuallyHiddenTexts">
<key alias="goBack">Gå tilbage</key>
</area>
</language>
5 changes: 4 additions & 1 deletion src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2127,5 +2127,8 @@ To manage your website, simply open the Umbraco back office and start adding con
<key alias="settingsProfiler">Profiling</key>
<key alias="memberIntro">Getting Started</key>
<key alias="formsInstall">Install Umbraco Forms</key>
</area>>
</area>
<area alias="visuallyHiddenTexts">
<key alias="goBack">Go back</key>
</area>
</language>
3 changes: 3 additions & 0 deletions src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2142,4 +2142,7 @@ To manage your website, simply open the Umbraco back office and start adding con
<key alias="memberIntro">Getting Started</key>
<key alias="formsInstall">Install Umbraco Forms</key>
</area>
<area alias="visuallyHiddenTexts">
<key alias="goBack">Go back</key>
</area>
</language>