Accessibility: Open User Details - Back icon arrow is identified as "Umbraco link" #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jan! Great bit of optimisation for a screen reader. These are always fun to test 😂 Em |
|
Yeah, we kinda need to figure out if we're actually using them right 😃 Once again I'm open towards feedback regarding the text... I mean ideally the "Back" text is pretty generic and lacks context, but I guess that for now it's better than nothing. But perhaps this kind of button should be made into a component where it's possible to pass an appropiate specific text so it can read "Back to the Users section" etc. - But this is better than what we currently have at least |
emmaburstow
approved these changes
Aug 13, 2019
# Conflicts: # src/Umbraco.Web.UI/Umbraco/config/lang/en_us.xml
|
Lovely updates @BatJan 👍 Thanks! |
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This PR then this fixes issue 111 from #5277
Description
This PR ensures that the text "Back" is read out to screen readers and the tag has been replaced with a tag, which fixes the button no longer being mentioned as an "Umbraco link" in a screen reader.
It is the button being shown in the users section when editing either groups or user profiles as shown in the images below.