Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Open Package - Identifies back button as "Left hand arrow back button" #5930

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Accessibility: Open Package - Identifies back button as "Left hand arrow back button" #5930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3475ba2
Refactor <a> to <button> and wrap &larr; unicode entity in a span wit…
BatJan Jul 17, 2019
8e08655
Also fix the button in examine management dashboard
BatJan Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Umbraco.Web.UI.Client/src/less/components/umb-packages.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,12 +264,16 @@
flex-flow: row wrap;
}

a.umb-package-details__back-link {
.umb-package-details__back-action {
font-weight: bold;
color: @black;
padding: 0;
border: 0;
background-color: transparent;
}

.umb-package-details__back-link:hover {
.umb-package-details__back-action:focus,
.umb-package-details__back-action:hover {
color: @gray-4;
text-decoration: none;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Umbraco.Web.UI.Client/src/views/dashboard/settings/examinemanagement.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ <h3 class="bold">Examine Management</h3>

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-panel-back-link" href="" ng-click="vm.setViewState('list');">&larr; Back to overview</a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.setViewState('list');"><span aria-hidden="true">&larr;</span> <localize key="general_backToOverview">Back to overview</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down Expand Up @@ -198,7 +198,7 @@ <h3 class="bold">Examine Management</h3>

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-panel-back-link" href="" ng-click="vm.setViewState('list');">&larr; <localize key="general_backToOverview">Back to overview</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.setViewState('list');"><span aria-hidden="true">&larr;</span> <localize key="general_backToOverview">Back to overview</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down
10 changes: 5 additions & 5 deletions src/Umbraco.Web.UI.Client/src/views/packages/views/install-local.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
ngf-max-size="{{ maxFileSize }}">
- <localize key="packager_orClickHereToUpload">or click here to choose files</localize>
</div>

</div>

</div>

<h3><strong><localize key="packager_uploadPackage">Upload package</localize></strong></h3>
Expand All @@ -54,7 +54,7 @@ <h3><strong><localize key="packager_uploadPackage">Upload package</localize></st

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.state = 'upload'">&larr; <localize key="packager_uploadAnother">Upload another package</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.state = 'upload'" prevent-default><span aria-hidden="true">&larr;</span> <localize key="packager_uploadAnother">Upload another package</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand All @@ -76,7 +76,7 @@ <h4 class="umb-info-local-item"><strong><localize key="packager_installStateUplo
<div class="umb-info-local-item text-error mt3" ng-if="vm.zipFile.uploadStatus === 'error'">
{{ vm.zipFile.serverErrorMessage }}
</div>

</div>
</div>
</div>
Expand All @@ -89,7 +89,7 @@ <h4 class="umb-info-local-item"><strong><localize key="packager_installStateUplo

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.state = 'upload'">&larr; <localize key="packager_cancelAndUploadAnother">Cancel and upload another package</localize></a>
<button type="button" class="umb-package-details__back-action" href="" ng-click="vm.state = 'upload'" prevent-default><span aria-hidden="true">&larr;</span> <localize key="packager_cancelAndUploadAnother">Cancel and upload another package</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down
2 changes: 1 addition & 1 deletion src/Umbraco.Web.UI.Client/src/views/packages/views/installed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ <h4><strong><localize key="packager_noPackages">You don’t have any packages in

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.state = 'list'">&larr; <localize key="general_back">Back</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.state = 'list'" prevent-default><span aria-hidden="true">&larr;</span> <localize key="general_back">Back</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down
6 changes: 3 additions & 3 deletions src/Umbraco.Web.UI.Client/src/views/packages/views/repo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ <h4><strong><localize key="packager_packageNoResults">We couldn't find anything

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.setPackageViewState('packageList');">&larr; <localize key="general_back">Back</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.setPackageViewState('packageList');" prevent-default><span aria-hidden="true">&larr;</span> <localize key="general_back">Back</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down Expand Up @@ -185,7 +185,7 @@ <h4><strong><localize key="packager_packageNoResults">We couldn't find anything
img-src="{{ 'https://our.umbraco.org' + vm.package.ownerInfo.ownerAvatar }}">
</umb-avatar>
</div>

<div>
<div class="umb-package-details__owner-profile-name">{{ vm.package.ownerInfo.owner }}</div>
<div class="umb-package-details__owner-profile-karma">
Expand Down Expand Up @@ -287,7 +287,7 @@ <h4><strong><localize key="packager_packageNoResults">We couldn't find anything
<div ng-if="vm.packageViewState === 'packageInstall' && vm.loading === false">
<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.setPackageViewState('packageDetails');">&larr; <localize key="general_back">Back</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.setPackageViewState('packageDetails');" prevent-default><span aria-hidden="true">&larr;</span> <localize key="general_back">Back</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down
6 changes: 3 additions & 3 deletions src/Umbraco.Web.UI.Client/src/views/users/views/users/users.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.setUsersViewState('overview');">&larr; <localize key="user_backToUsers">Back to users</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.setUsersViewState('overview');"><span aria-hidden="true">&larr;</span> <localize key="user_backToUsers">Back to users</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down Expand Up @@ -408,7 +408,7 @@ <h3 class="bold" style="margin-bottom: 0;">

<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.setUsersViewState('overview');">&larr; <localize key="user_backToUsers">Back to users</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.setUsersViewState('overview');"><span aria-hidden="true">&larr;</span> <localize key="user_backToUsers">Back to users</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down Expand Up @@ -490,7 +490,7 @@ <h3 class="bold" style="margin: 0 0 0 10px;">
<div ng-if="vm.usersViewState === 'inviteUserSuccess'">
<umb-editor-sub-header>
<umb-editor-sub-header-content-left>
<a class="umb-package-details__back-link" href="" ng-click="vm.setUsersViewState('overview');">&larr; <localize key="user_backToUsers">Back to users</localize></a>
<button type="button" class="umb-package-details__back-action" ng-click="vm.setUsersViewState('overview');"><span aria-hidden="true">&larr;</span> <localize key="user_backToUsers">Back to users</localize></button>
</umb-editor-sub-header-content-left>
</umb-editor-sub-header>

Expand Down