Accessibility: Open Package - Identifies back button as "Left hand arrow back button" #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the aria-hidden attribute set to true and fixing the styling
BatJan
changed the title
|
Yay! Another win for accessibility. Thanks Jan, Em |
|
Sweet! Thanks @BatJan! ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
This fixes issue 104 and 117 from #5277
Description
This PR wraps every found instance of the unicode character ← in a aria-hidden="true" element so screen reader don't read it out loud, since it does not make much sense.
Also all of the places where the back button was used are refactored from
<a>to<button>and styling has been fixed accordingly. Once this PR is approved I'll have a look at making some kind of button component since I noticed the exact same look and feel being implemented differently in the examine dashboard 😃