U4-9367 Refined context menu for content in the recycle bin #2687
Conversation
|
Hi , Many thanks for your PR.We shall review your PR and get back to you within the next 14 days. Regards, |
There was a problem hiding this comment.
Hi @ed-parry - I think the only options here that make real sense are Restore, Delete and Reload. The rest should be done on content that is actually in the content tree (especially sort!). Could you remove Sort, Rollback and Audit Trail options please?
|
Hi @nul800sebastiaan - I agree on the sort and rollback, but do you not think there could be value in a user reviewing the audit trail to understand why and/or who deleted the content, as that could be useful information as to whether it should be restored? I'll make the changes this week and update :) Thanks for taking the time to review! |
|
Sure.. I guess the audit trail might still make sense, although I'm not even sure if the deletion is recorded in there. But sure, let's keep it for now, even if just for edit history! 👍 |
|
The deletion is recorded in the audit trail and you have the full history in the info tab. I think we should remove the audit trail also. At some point, we will remove the audit trail from the context menu anyway. |
|
Good point, @madsrasmussen - forgot about the info tab. I'll remove all three then, since the record is available elsewhere. |
|
@nul800sebastiaan Updated :) quick question, fixes like this - how would they get into V8 - are V7 fixes getting merged in automatically, or is it a case of seeing if the same issue applies and making the changes specifically in the V8 branch? |
|
@ed-parry Everything in v7 gets merged up to v8, so yep, only have to do the changes once! |
|
@ed-parry Thanks for the quick update! And it all works as expected! 👍 |
Prerequisites
Description
This is a potential solution to U4-9367. An old issue, but it makes sense to clean up the context menu for items in the recycle bin. It doesn't look like the original issue is still active (the restore menu appearing for items "moved" from the recycling bin), but having multiple methods is confusing and the restore option is there for a reason.
The new context menu for items in the recycling bin looks as below. I added a new method to build up the menu, rather than pulling items out of the default one.
Happy to make further changes as required. The items left in the menu make sense to me and work in that context, but focus on the user either restoring or permanently deleting the content.