Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow moving items from recycle bin to parents that allow children of this type #4142

Closed
bjarnef opened this issue Jan 18, 2019 · 6 comments

Comments

@bjarnef
Copy link
Contributor

bjarnef commented Jan 18, 2019

Edit: note, this turned into a feature request with this comment: #4142 (comment)

In this PR #2687 it added the "Restore" action to nodes in recycle bin.

However if I move a node to recycle bin in default starter kit, e.g. an blog post it wants to restore under "Blog" node, but if the blog node also is allowed under home node, am I not able to move this to child node of home node. Instead I would have to restore (under blog node) and then move the node under home node.
Furthermore if the paren node "Blog" node also is recycle bin it can't restore.

However it seems that you can move the nodes from the recycle bin listview with bulk actions.

I think it still should be possible to move nodes from recycle bin to nodes where these are allowed as child node.

@kjac
Copy link
Contributor

kjac commented Jan 18, 2019

Pretty sure I did a lot of fixing in this area. What version are you running?

@kjac
Copy link
Contributor

kjac commented Jan 19, 2019

@bjarnef for content it should be in 7.13:

image

See also #3772.

I'm pretty sure it was already there for media before 7.13, but 7.14 brings some improvements to it. See #3914.

@bjarnef
Copy link
Contributor Author

bjarnef commented Jan 20, 2019

@kjac ahh sorry, I was checking new features and bug fixes in different minor version from v7.10 to v7.13 .. but was looking at v7.11 where the restore action was added and move action removed.
https://our.umbraco.com/download/releases//7110

I just checked in v7.13.1 and the move action is back! 😁

One thing that would be great for move action for a deleted node (or move in general) that you only can select the parent node (or root) under which the node are allowed to be created, e.g. here I can select any node in the tree, but the "My Blog Post" node is only allowed to be created under "Blog" node.

image

@kjac
Copy link
Contributor

kjac commented Jan 20, 2019

@bjarnef that would be ideal yeah.. but not terribly easy to do. You should get a meaningful error if you try, though?

@nul800sebastiaan
Copy link
Member

That's a rather large feature request, but it could be cool if the move would show you faded tree items and a "stop sign" icon when you're not allowed to move things to that parent. I don't know how much work that would be and if it's worth it. It's a good one to investigate the feasibility of though.

I've marked this as "Up for grabs" so that you or someone else coming along could create a pull request for it.

@nul800sebastiaan nul800sebastiaan changed the title Add move action for deleted content and media Only allow moving items from recycle bin to parents that allow children of this type. Mar 7, 2019
@nul800sebastiaan nul800sebastiaan changed the title Only allow moving items from recycle bin to parents that allow children of this type. Only allow moving items from recycle bin to parents that allow children of this type Mar 7, 2019
@nul800sebastiaan
Copy link
Member

This issue has been in the up for grabs state for quite a while now and it seems nobody is ready to pick this one up.

For now we'll close this issue to prevent the list of up for grabs from becoming very stale. We're happy to re-open it if someone still thinks it's good to work on this.

If anyone is about to pick this issue up to fix it, make sure to test first if you can reproduce the problem in the latest version before you start to work on it.

Thanks!
Sebastiaan on behalf of Umbraco HQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants