v12: Rename V2 to Umbraco.Cms.Imaging.ImageSharp2 #14223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldbarendse
commented
May 9, 2023
src/Umbraco.Cms.Imaging.ImageSharp2/Umbraco.Cms.Imaging.ImageSharp2.csproj
Show resolved
Hide resolved
|
Hey @ronaldbarendse, thanks for your interest, I had a chat with Bjarke about it this morning, and we do not want to have the version number in the current ImageSharp version (So no ImageSharp3), our reasoning is that we don't want the confusion of have ImageSharp3, ImageSharp4, etc. And not knowing which is the recommended version, However ImageSharp.V2 is a particular case because of the licensing change, so that's why it's there, so ImageSharp is default and ImageSharp.V2 is if you want to use the old version |
ronaldbarendse
changed the title
bergmania
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on #14216 (comment) (and later discussed internally), this now renames the
Umbraco.Cms.Imaging.ImageSharp.V2project toUmbraco.Cms.Imaging.ImageSharp2. TheUmbraco.Cms.Imaging.ImageSharpproject will then always reference the latest version when releasing a new CMS major.I've included the major version in the v2 package title/description and renamed the namespace, so you don't have to update any references in your own code when switching from the latest version back to version 2.