Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V12: Update ImageSharp V3 and Add Legacy V2 Project #14216

Merged
merged 3 commits into from
May 9, 2023

Conversation

nikolajlauridsen
Copy link
Contributor

This PR takes #14180 but instead of just upgrading the ImageSharp project to V3, it also adds the old V2 version as a separate project.

For more info see #14180

As for testing as also stated in the other PR, the tests should pass and you should be able to get a cropped image.

@nikolajlauridsen nikolajlauridsen changed the title V12: Update ImageSharp V3 and Legacy V2 Project V12: Update ImageSharp V3 and Add Legacy V2 Project May 8, 2023
@Zeegaan
Copy link
Member

Zeegaan commented May 9, 2023

LGTM 👍

@Zeegaan Zeegaan merged commit 5e9ce91 into v12/dev May 9, 2023
@Zeegaan Zeegaan deleted the v12/feature/imagesharpd_v3 branch May 9, 2023 08:09
@ronaldbarendse
Copy link
Contributor

Just a note about naming of the projects/packages: I would suggest always including the major version of the dependency, e.g. Umbraco.Cms.Imaging.ImageSharp3 and Umbraco.Cms.Imaging.ImageSharp2 (using Umbraco.Cms.Imaging.ImageSharp.V2 could infer there might be a dependency on Umbraco.Cms.Imaging.ImageSharp, which isn't the case).

Besides being more clear on what major version the dependency is used, this will also be much better for future-proofing, especially if we'd like to support a future ImageSharp 4 dependency on our CMS v13 LTS version (which could then be released as Umbraco.Cms.Imaging.ImageSharp4 - nice, simple and most of all, logical).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file release/12.0.0 type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants