Remove the need of Smtp.Host config when using PickupDirectoryLocation

[mikecp]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #11249 (addition to current fix)

Description

In the continuation of PR #11253 that was merge a few days ago, I noticed afterwards that when using the PickupDirectoryLocation SMTP setting, the "forgot password" link on the backoffice login page would only be displayed in case we also specified a Host in the SMTP settings, which is kind of illogic.

This PR solves that issue and now the display of the "forgot password" link on the login page is displayed when either Host, either PickupDirectoryLocation is specified.

Testing:

Specify a valid PickupDirectory location and a From address in the appsettings.json (or appsettings.development.json), cf. example below , and check that the "forgot password" link is displayed on the login screen.

"Umbraco": {
"CMS": {
"Examine": {
"LuceneDirectoryFactory": "TempFileSystemDirectoryFactory"
},
"Global": {
"Smtp": {
"PickupDirectoryLocation": "D:\Mails Pickup",
"From": "[email protected]",
//"Host": "localhost"
// "Port": "25"
}
},

[shearer3000]

hello- should this be fixed in umbraco 9.1.0 now? I tried the following settings and the 'forgot password' link still doesn't show:

"Smtp": { "From": "[email protected]", "DeliveryMethod": "SpecifiedPickupDirectory", "PickupDirectoryLocation": "C:\\Temp\\MailDrop\\" }

thanks
Andrew

[mikecp]

Hi @andrewdeans ,

This PR has not been merged yet, so it is not available in umbraco 9.1.0. Let's hope it makes it to 9.2.0 😁🤞

Cheers,

Michael.

[shearer3000]

ok thanks @mikecp yes lets hope 🤞

[harvzor]

Seems to work in Umbraco 9.2!

My project has been upgraded from version 7 and I was using SmtpClient to send email before. This client didn't seem to take notice of my appsettings.json setup:

{
  "Umbraco": {
      "Global": {
        "Smtp": {
          "DeliveryMethod": "SpecifiedPickupDirectory",
          "PickupDirectoryLocation": "C:\\D\\Dev\\Tech\\artists-name-plates\\Mail",
          "From": "[email protected]"
        }
      }
    }
  }
}

I switched to using IEmailSender (as documented here https://codeshare.co.uk/blog/how-to-send-emails-in-umbraco-9-using-iemailsender/) and it finally worked.

Thanks!

[mikecp]

Hey @harvzor , glad you got it working 😁