Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] Fix the basehttpheader health check so that it's checking the root of the domain instead of the /umbraco path #11534

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

Jeavon
Copy link
Contributor

@Jeavon Jeavon commented Oct 28, 2021

Fix the basehttpheader health check so that it's checking the root of the domain instead of the /umbraco path.

It should be this way anyway especially if meta tags are being checked instead of headers.

Additionally, on Umbraco Cloud these tests are all passing (even if wrong) as it's actually checking https://identity.umbraco.com for headers

This makes it consistent with the ExcessiveHeadersCheck.cs also

@umbrabot
Copy link

umbrabot commented Oct 28, 2021

Hi there @Jeavon, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Jeavon Jeavon changed the title Fix the basehttpheader so that it's checking the root of the domain i… [v8] Fix the basehttpheader so that it's checking the root of the domain i… Oct 28, 2021
@Jeavon Jeavon changed the title [v8] Fix the basehttpheader so that it's checking the root of the domain i… [v8] Fix the basehttpheader health check so that it's checking the root of the domain instead of the /umbraco path Oct 28, 2021
@mikecp
Copy link
Contributor

mikecp commented Oct 29, 2021

Thanks Jeavon for this PR, it's nice keeping V8 and V9 in sync😉

@Jeavon
Copy link
Contributor Author

Jeavon commented Oct 29, 2021

Thanks @mikecp it's interesting when you see a bug that affects both 8 and 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants