Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete method #11277

Merged

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Oct 5, 2021

Fixes: #11081

Notes

  • Removed obsolete migration method from UmbracoPocoDataBuilder

How to test

  • Run a clean install
  • When the tour popup shows, press "do not show again"
  • Reload the page and verify that the popup doesn't show
  • Create a migration class, I used this:
namespace Umbraco.Cms.Infrastructure.Migrations
{
    public class MyMigration : MigrationBase
    {
        public MyMigration(IMigrationContext context) : base(context)
        {
        }

        protected override void Migrate()
        {
            
        }
    }
}
  • Create a fake migration in UmbracoPlan.cs with To<MyMigration>("47C4C7DF-4977-45F6-A6D4-8DC727BC8FE7");
  • Run Umbraco and run the migration by pressing continue
  • Verify that the tour popup doesn't show

Nikolaj Geisle added 2 commits October 5, 2021 13:41
Signed-off-by: Nikolaj Geisle <[email protected]>
Signed-off-by: Nikolaj Geisle <[email protected]>
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to wait for the build server to be happyy

@nikolajlauridsen nikolajlauridsen merged commit a013cfb into v9/9.0 Oct 5, 2021
@nikolajlauridsen nikolajlauridsen deleted the v9/bugfix/11081_userRepo_doesnt_retrieve_tourdata branch October 5, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants