Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.0.0-beta003] PostSetUserTour doesn't seem to persist until apppool recycle #11081

Closed
LennardF1989 opened this issue Sep 12, 2021 · 5 comments

Comments

@LennardF1989
Copy link
Contributor

LennardF1989 commented Sep 12, 2021

Which exact Umbraco version are you using? For example: 8.13.1 - don't just write v8

v9.0.0-beta003

Bug summary

Upon upgrading from 002 to 003, clicking "Don't show this tour again", doesn't seem to actually persist. On next refresh, it will simply popup again.

Only after I did a recycle of the apppool, did it stop bothering me.

Specifics

No response

Steps to reproduce

Upgrade a beta002 to beta003, login, click "Don't show this tour again", then refresh. The popup will show again.

Expected result / actual result

The popup doesn't come back.


This item has been added to our backlog AB#13863

@bergmania bergmania added project/v9 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels Sep 13, 2021
@nul800sebastiaan
Copy link
Member

I can reproduce, it's saving my TourData correctly but apparently not reading it correctly again after that:

image

@Zeegaan
Copy link
Member

Zeegaan commented Sep 22, 2021

This is a bit embarrasing but i've been looking at this issue the past few days, and I just cannot find out what causes this bug.

I can replicate the issue just as described, and I've been doing some digging 🕵️
It seems that we save the TourData of the User just fine in the database, but something goes wrong in the cache, when I'm stepping through it.

It clears just fine, and the new TourData is saved in the cache, but all of a sudden it just comes back for no apparent reason, so until we can find out what is causing this Issue, the workaround sadly has to be that you just recycle the app pool 😖

@nul800sebastiaan
Copy link
Member

Thanks @Zeegaan - let's go with the "solution" being: recycle the app pool. It fixes the problem and the tour popup seems to behave properly after that! I'll close this issue for now but let us know if that doesn't seem to help for you @LennardF1989!

@nul800sebastiaan nul800sebastiaan removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Sep 22, 2021
@LennardF1989
Copy link
Contributor Author

This is acceptable for me :) I think the bigger question is: what causes the cache to reintroduce a cleared value. If it happens here, I can only assume it happens elsewhere as well, potentially even during runtime operation of the CMS itself - which is a lot more concerning than me having the recycle to get rid of the tour popup :P

@Zeegaan
Copy link
Member

Zeegaan commented Oct 5, 2021

I found out what was causing the issue, it was an artifact from migrating from 7.11 - 7.12, and we had to ignore tourdata when updating! This is now obsolete and has been removed in #11277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants