-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes various issues with javascript services #10800
Fixes various issues with javascript services #10800
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
@nul800sebastiaan this fixes part of the the issue, but it seems gulp doesn't compile all changes, e.g. the Apparently the changes in regarding |
Aha! Now I understand what you meant with the array check! I amended it to also update the null check like you suggested yesterday - 0404670 |
Thanks for the quick assist @bjarnef, you're a star! ⭐ |
Prerequisites
Description
This fixes some issues after recent PRs has been merged, e.g.
closeBackdrop
innavigationService
which wasn't a public function. However instead of exposingcloseBackdrop
innavigationService
I think it makes more sense the callnavigationService.hideMenu()
which also close backdrop. In fact I thinkbackdropService
should be responsible for logic regarding backdrops.