Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes various issues with javascript services #10800

Merged
merged 7 commits into from
Aug 6, 2021

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Aug 5, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This fixes some issues after recent PRs has been merged, e.g. closeBackdrop in navigationService which wasn't a public function. However instead of exposing closeBackdrop in navigationService I think it makes more sense the call navigationService.hideMenu() which also close backdrop. In fact I think backdropServiceshould be responsible for logic regarding backdrops.

@umbrabot
Copy link

umbrabot commented Aug 5, 2021

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 5, 2021

@nul800sebastiaan this fixes part of the the issue, but it seems gulp doesn't compile all changes, e.g. the isArray(obj) changes in this PR.
Furthermore with latest changes in v8/contrib branch and these changes, the seach overlay looks strange.

image

Apparently the changes in regarding .umb-search-input.umb-search-input in PR #10735 affected the search input styling (not sure why) however changing back to ``.umb-search-input.umb-search-inputorinput.umb-search-input` seems to work.
Fixed in a62c990

image

@bjarnef
Copy link
Contributor Author

bjarnef commented Aug 5, 2021

Maybe it just took some time to compile the JS or something was cached (although I refreshed and cleared browser cache).
Anyway now I don't get the console error:

image

image

@nul800sebastiaan
Copy link
Member

Aha! Now I understand what you meant with the array check! I amended it to also update the null check like you suggested yesterday - 0404670

@nul800sebastiaan nul800sebastiaan merged commit 137be33 into umbraco:v8/contrib Aug 6, 2021
@nul800sebastiaan
Copy link
Member

Thanks for the quick assist @bjarnef, you're a star! ⭐

@bjarnef bjarnef deleted the v8/bug/service-fixes branch August 6, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants