Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examine dashboard search adjustments #10735

Merged

Conversation

bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Jul 25, 2021

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This PR add a few adjustments to Examine dashboard in Settings section:

  • Replace search input with <umb-search-filter> component.
  • Replace icons with <umb-icon> component.

Currently <umb-search-filter> only acted on change, but not on a keypress/keydown event, e.g. search on enter.
I have handled this a bit similar to have it works in umbMiniSearch which has an onSearch function.

We could in this case call the function onFilter, but I thought it might be to close to the onChange function.

Test notes

  • Check Examine search works searching via enter in search input and when clicking Search button. With default starter kit search e.g. on "home".
  • Test filtering on e.g. Icon Picker still works.

@bjarnef bjarnef marked this pull request as ready for review July 25, 2021 14:32
@umbrabot
Copy link

umbrabot commented Jul 25, 2021

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@bjarnef bjarnef changed the title Examine search adjustments Examine dashboard search adjustments Jul 25, 2021
@nul800sebastiaan
Copy link
Member

Thanks @bjarnef, I found a funny one:

image

Didn't look too healthy.. ;-)

But that seems to have been a copy/paste error, I fixed it here: 75007df (#10735)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants