-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examine dashboard search adjustments #10735
Examine dashboard search adjustments #10735
Conversation
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Thanks @bjarnef, I found a funny one: Didn't look too healthy.. ;-) But that seems to have been a copy/paste error, I fixed it here: |
Prerequisites
Description
This PR add a few adjustments to Examine dashboard in Settings section:
<umb-search-filter>
component.<umb-icon>
component.Currently
<umb-search-filter>
only acted on change, but not on a keypress/keydown event, e.g. search on enter.I have handled this a bit similar to have it works in
umbMiniSearch
which has anonSearch
function.Umbraco-CMS/src/Umbraco.Web.UI.Client/src/common/directives/components/umbminisearch.component.js
Line 13 in d428a45
We could in this case call the function
onFilter
, but I thought it might be to close to theonChange
function.Test notes