#10354 - added domain content id as node context for the content find…

[kmeilander]

…er for the 404 error page so $site works

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #10354

Description

I needed to make different 404 pages for different sites and so wanted to use $site in the xPath. This doesn't currently work since the nodeContextId in the xpath isn't set.

However, when we get the domain as part of the PublishedRequest, we also get the content id of the site for that domain so we can use this to pass in the site context to the xpath query and make $site work. I think $current will also look at the site root.

I opened a issue with more details around this. #10354

To test this, setup multiple sites with multiple domains that have an error pages setup. Then configure the error404 using xPath and $site. See that each domain returns different nodes.

See the ticket for more details around this issue.

[umbrabot]

Hi there @kmeilander, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[ronaldbarendse]

It does indeed make sense to use the (automatically) resolved domain content ID as $site variable 👍🏻

I think we should also make resolving the Domain/DomainAndUri more open, so this can be done outside of the current Umbraco request, like in custom HTTP modules for generating sitemaps or doing redirects. I've seen a lot of duplicate code because of this exact use-case:

• https://our.umbraco.com/packages/website-utilities/friendly-sitemap/, which uses https://github.com/callumbwhyte/umbraco-routing-extensions
• https://github.com/skybrud/Skybrud.Umbraco.Redirects/blob/v2/latest/src/Skybrud.Umbraco.Redirects/Domains/DomainUtils.cs

[nul800sebastiaan]

Sorry for the long delay on this one @kmeilander! This is now merged and ready for the next release, good stuff! 👍