Configure 404 error page per site using XPath

[kmeilander]

Which Umbraco version are you using?

8.6

Bug summary

When configuring my site's error404 page using XPath, I cannot use a $site to specify the page in relation to the requested site.

Specifics

No response

Steps to reproduce

On an instance with 2 sites with different domains, configure a 404 Error page in the umbracoSettings.config using an XPath using the $site tag.

Such as:

  <errors>
     <error404>$site//error[@nodeName='404']</error404>
   ...

Make sure you have a page setup in each site at that XPath and then go to a non existent URL for each of the 2 domains.

Expected result / actual result

EXPECTED: For each site i see the corresponding error page.

ACTUAL: Both sites show the same error page, the first one in the content tree.

[emma-hq]

Hey @kmeilander,

Thanks for reporting this one and thanks also for the PR associated with it. We'll take a look at both and let you know our thoughts.

Emma

[umbrabot]

Hi @kmeilander,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[kmeilander]

@emma-hq thanks. It's quite possible there's a good reason why my fix is a bad idea and shouldn't be done that way, but I couldn't think of anything.

Let me know if you need anything.