Entity resource getByIds doesn't work as expected

[bjarnef]

Which exact Umbraco version are you using? For example: 8.13.1 - don't just write v8

9.0.1

Bug summary

In v8 we could pass in an array to entityResource.getByIds() to fetch documents, medias etc.

entityResource.getByIds([1173, 1180, 1162, 3233], "Media")
      .then(function (entities) {
              $scope.images = entities;
      });

According to docs this should be an array:
https://github.com/umbraco/Umbraco-CMS/blob/v9/contrib/src/Umbraco.Web.UI.Client/src/common/resources/entity.resource.js#L224-L265

I tried with int ids, udis and Guid, but all seems to fail.

Specifics

No response

Steps to reproduce

Request some media items / nodes from id, udi or guid via a dashboard or similar.

entityResource.getByIds([1173, 1180, 1162, 3233], "Media")
                .then(function (entities) {
                    $scope.images = entities;
                });

Expected result / actual result

No response

---

This item has been added to our backlog AB#15137

[bjarnef]

I also suggested this a year ago so we can fetch content and media by id, udi and guid (not slim entities).
#9465

[bjarnef]

It seems to fail somewhere here: https://github.com/umbraco/Umbraco-CMS/blob/v9/contrib/src/Umbraco.Web.BackOffice/Controllers/EntityController.cs#L512

entityResource.getByIds() should be able to lookup entities from int[], Guid[] and Udi[].

[AndyButland]

Looks like there might be an issue with the ParameterSwapControllerActionSelector attribute added to that class. That should be detecting which of the three GetByIds methods to use. I can see here you are passing int[] but it looks to have matched one of the other methods in the controller, hence the attempt to convert to Guid in the error message you are seeing.

[bjarnef]

@AndyButland I can't find something specific recently has changed in EntityController or ParameterSwapControllerActionSelectorAttribute.

For the specific request I am looking at now from MNTP it has the content nodes selected, but since the request fails it doesn't show nodes in the repeat using <umb-node-preview>.

It use the first Udi, but for some reason it then can't convert this to an Guid.
I think it is failing here: https://github.com/umbraco/Umbraco-CMS/blob/v9/contrib/src/Umbraco.Web.BackOffice/Controllers/EntityController.cs#L512

[bjarnef]

Btw. the first examples with int[] was some hardcoded ids from controllers for custom block views.
The latter one from core MNTP which store udis and lookup these from entity resource.

[bjarnef]

I cloned latest changed from v9/contrib branch and installed the starterkit package.

I could use the following the fetch media:

entityResource.getByIds([1172, 1173], "Media")
    .then(function (entities) {
        console.log("entities", entities);
    });

but when I use udi instead it throws an exception:

entityResource.getByIds(['umb://media/cf1ab8dcad0f4a8e974b87b84777b0d6', 'umb://media/eee91c05b2e84031a056dcd7f28eff89'], "Media")
    .then(function (entities) {
      console.log("entities", entities);
    });

[bjarnef]

I also noticed similar issues with other pickers in default starterkit installed:

Home

Products

[bjarnef]

However when I ran the site with debugging through IIS Express it started working.

Afterwards when running without debugging it seems to work just fine 🤔