-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.0] Failing generating models when changing property property editor #176
Comments
@bjarnef Interesting, a similar scenario was mentioned here: #173 (reply in thread) I believe it's an Umbraco bug. In that a Content Type seems to cache the Property Editor alias, so that when a DataType is modified, e.g. the Property Editor is changed, the Content Type still references the old one. The only way it appears to invalid it is to open the Content Type and re-save it. |
@leekelleher yeah, it may be related, but not sure if the issue is the same. But it seems I still get the Then I have to discard the changes and re-build to start application again 🤐 So yeah, it is weird 🙄😛 Furthermore is isn't useful to log "ConfigField" - I think it actually should log the name of the field 😅 |
@leekelleher I removed all Contentment datatype instances and the models generating works. However when I add a new datatype instance e.g. "Text Alignment" using |
@bjarnef To clarify, are you saying that the ModelsBuilder generation always throws an error for Contentment data-types? Regardless of changing the doctype's property? |
@leekelleher yes, it seeems so. When I generate models all is good, but when I then create a new datatype "Text Alignment" using the I tried refreshing the various caching from NuCache dashboard just to see if that made a difference, but unfortunately not. |
Okay, I had a few Contentment datatypes, which I deleted again.. but still got the errors. However when was browsing content I noticed this error on a Testimonial block (using Block List editor). StackTrace:
This block was using a settings element type with a "Layout" property, which used Contentment Datalist and enum data source. I re-saved the element type and will check further. |
If I remove the block and try to insert it again I get the same error. Unfortunately I had to uninstall Contentment in this specific project for now since it seemed to cause issues with generation of modes, but I will probably try again sometime later or in a test site 🤗 |
The I'll try to reproduce the ModelsBuilder issue during this week, and I'll feedback on here. |
Even though I have uninstalled Contentment I get the error in #176 (comment) where it has a property using MNTP. If I change to a textarea I don't see any specific value in the property and submit from block overlay doesn't fail. However going back to MNTP again makes it fail again 😬🙈 |
@leekelleher ahh the the log actually show the "ConfigField" as a separate property with value "preview". It seems it may be an issue with this "preview" config field. https://github.com/leekelleher/umbraco-contentment/blob/develop/src/Umbraco.Community.Contentment/DataEditors/DataList/DataListConfigurationEditor.cs#L87-L92 |
@bjarnef Can we clarify what the issue is here, as I'm confused. These Or is it the |
@leekelleher yes, I think these are just warnings and not specific related to this issue. Actually I think it is different issue. I removed Contentment package from the project for now, but still get the JSON errors. It seems to be related to MNTP where some previous selected content nodes no longer are rendered in the property editor view using I noticed I started getting POST errors from entity resource: umbraco/Umbraco-CMS#11448 I am not sure what cause the error though, maybe a bug in Umbraco v9.0.1, Umbraco Forms or other Cloud specific logic. |
@leekelleher I gave it another try with Contentment v3.0.1, but I can't really reproduce this now. I could switch property editors of existing datatypes and the models are generated. |
I can see various controllers has Okay, it seems to be a hidden feature, which even GitHub search can't find 😅 |
I think the missing registred services and controllers may be an issue with Smidge which are bundling the assets on Umbraco Cloud, but not locally. I have also noticed this started happening for my own controllers used the block custom views and this where the external login providers are missing: umbraco/Umbraco.Cloud.Issues#476 (comment) |
I get a feeling that Smidge is attempting to minify Contentment's already minified JS. I thought I'd tested for this, but will take another look. |
@bjarnef I've separated out the v9/Smidge issue (which I believe is caused when debug=false on v9) to #185. With the original issue, e.g. "Failing generating models when changing property property editor". Am I correct in thinking that is no longer an issue? (I feel like there were a few things going on in this thread, so a little lost what I should be concerned with. 😅 ) |
@leekelleher yeah, I couldn't reproduce the second time I tried the package. Maybe it was due the build errors in v3.0.0 which was fixed in v3.0.1 |
@leekelleher I think the JS errors was caused by another JS asset not being bundled due an error, which seemed the cause other JS assets not being registered/bundled. See: RE the "other" issue with failing generating models. However when running through IIS Express it didn't seem to be an issue. v54bPPeimy.mp4I suspect it is an issue when running 4j3nBcoyYz.mp4It seems from the command it detect a change and then start building project, but before all models are generated I guess.
|
The JSON exception also doesn't seem to be related to Contentment, but may be a bug in Umbraco core. |
Which Contentment version are you using?
3.0.0
Which Umbraco version are you using? For example: 8.14.1 - don't just write v8
9.0.1
Bug summary
I am not sure if this issue is a bug in Contentment or it may be a Umbraco core issue.
However I had a existing datatype using radiobutton list and changed property editor to use
[Contentment] Data List
.When I re-generated models, the model generation failed and I noticed these errors in log file:
I have instead deleted the datatype instance from scratch using
[Contentment] Data List
property editor.I am using ModelsBuilder
SourceCodeManual
models mode.Steps to reproduce
[Contentment] Data List
, select an enum using the following (the icon is probably not necessary to set to reproduce):Expected result / actual result
No response
Do you have Umbraco ModelsBuilder enabled?
What browsers are you seeing the problem on?
Chrome
The text was updated successfully, but these errors were encountered: