feature/change-contact-consent-to-read-only #7392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopkinsmade
force-pushed
the
feature/change-contact-consent-to-read-only
branch
from
af61a75 to
09edb1f
Compare
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
feature/change-contact-consent-to-read-only
|
| Run status |
|
| Run duration | 01m 48s |
| Commit |
|
| Committer | Chris Hopkins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
15
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7392 +/- ##
==========================================
+ Coverage 87.99% 88.00% +0.01%
==========================================
Files 1168 1170 +2
Lines 18171 18173 +2
Branches 5139 5138 -1
==========================================
+ Hits 15990 15994 +4
+ Misses 2181 2179 -2 ☔ View full report in Codecov by Sentry. |
chopkinsmade
changed the title
cgsunkel
approved these changes
Dec 13, 2024
baarkerlounger
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As the legal basis API is being turned off, data hub will no longer be responsible for capturing consent from users. This responsibility will move to Microsoft Dynamics. As part of this change, a file will be delivered to datahub containing a list of users and their consent detail. This is already being ingested into the API, and made available on the /contact/UUID endpoint under the json property
consent_data.This change removes the ability for a datahub user to make a change to the Email marketing form field on the contact page, and introduces a new section for displaying a read only view of the contacts consent detail.
Once this change is merged, the PR uktrade/data-hub-api#5857 will remove all legal basis API fields from the API
Test instructions
Running the frontend locally, connected to a local instance of the API, these 2 examples can be used for testing:
Screenshots
Before
After
Checklist