Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feature/remove-legal-basis-api-connection #5857

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Dec 13, 2024

Description of change

As the legal basis API is being decommissioned, the datahub functions that use that service need to be updated to remove that connection.

For reference, inside datahub the legal basis API is called the consent service

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (e5396bb) to head (171c71e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5857      +/-   ##
==========================================
- Coverage   96.63%   96.60%   -0.04%     
==========================================
  Files        1057     1056       -1     
  Lines       25145    25008     -137     
  Branches     1668     1660       -8     
==========================================
- Hits        24300    24160     -140     
- Misses        689      691       +2     
- Partials      156      157       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade force-pushed the feature/remove-legal-basis-api-connection branch from e596012 to b677f62 Compare December 13, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant