Workflows without poetry #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sosnowsky
requested changes
Jul 21, 2023
docs/blob_shapes.rst
Outdated
| The blob shape consists of two parts, the blob shape in the propagation direction and the blob shape in the perpendicular direction thereof. | ||
| The propagation direction is calculated from vx and vy of each individual blob (see :ref:`blob-alignment` for further details). | ||
|
|
||
| The blob shape in the perpendicular direction is always set to "gauss", whereas you can choose one of the following blob shapes for the propagation direction: |
There was a problem hiding this comment.
The blob shape in the perp direction can also be set to any shape, "gauss" is just the default.
tests/test_blob.py
Outdated
| blob_factory=bf, | ||
| ) | ||
| _ = one_blob.make_realization() | ||
| _ = one_blob.get_blobs() |
There was a problem hiding this comment.
Is this just to cover some lines of code? Add some asserts (feks, number of blobs or any other thing that is constant)
Sosnowsky
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the mypy check were wrongly passing for moths. A number of type checking issues have been accumulated in the last months. This PR fixes these issues and sets up the workflows without poetry.
I also recreated the pyproject.toml file since the old one was created by poetry.
Also a few more tests are added.
I also added a new (and hopefully better) Readme to the repo.
The created docs are on readthedocs:
https://blobmodel.readthedocs.io/en/latest/