Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ort addition #928

Closed

Conversation

MinsukJi-NOAA
Copy link
Contributor

@MinsukJi-NOAA MinsukJi-NOAA commented Nov 23, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

Operation requirement test (ORT) for:

  • cpld_control_p7 thread and decomposition tests
  • cpld_bmark_p7 thread and decomposition tests
  • Due to the wave component in these tests, restart and debug do not work

Issue(s) addressed

#919

Testing

The following ORT tests pass:

  • control_p7: thread, decomposition, restart, debug, 64 bit
  • cpld_control_c96_p7: thread, decomposition, restart, debug
  • cpld_control_p7: thread, decomposition
  • cpld_bmakr_p7: thread, decomposition

Results do not change because only the ORT related files are modified in this PR.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

No dependencies

@github-actions
Copy link

@MinsukJi-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • cice NOT up to date

@github-actions github-actions bot removed the run-ci label Dec 15, 2021
@DusanJovic-NOAA DusanJovic-NOAA added the No Baseline Change No Baseline Change label Dec 15, 2021
@MinsukJi-NOAA
Copy link
Contributor Author

This PR will be combined with #931

@MinsukJi-NOAA
Copy link
Contributor Author

Code changes merged via #931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants