Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operation requirement tests #919

Closed
MinsukJi-NOAA opened this issue Nov 17, 2021 · 5 comments
Closed

Add operation requirement tests #919

MinsukJi-NOAA opened this issue Nov 17, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@MinsukJi-NOAA
Copy link
Contributor

Description

Make the operation requirement test scripts work for cpld_bmark_p7 and cpld_control_p7 tests.

@MinsukJi-NOAA MinsukJi-NOAA added the enhancement New feature or request label Nov 17, 2021
@MinsukJi-NOAA MinsukJi-NOAA self-assigned this Nov 17, 2021
@MinsukJi-NOAA
Copy link
Contributor Author

@DeniseWorthen @junwang-noaa cpld_bmark_p7 restart test fails to reproduce. I am not entirely sure if I am using all the correct parameters. To compare, I ran a successful restart test for cpld_control_c96_p7; please see the comparisons below.

For cpld_bmark_p7:

[Minsuk.Ji@hfe10 cpld_bmark_p7_rst]$ diff model_configure /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_OPNREQ_TEST/opnReqTest_250759/cpld_bmark_p7_std_base/model_configure 
9c9
< fhrot:                   3
---
> fhrot:                   0
[Minsuk.Ji@hfe10 cpld_bmark_p7_rst]$ diff nems.configure /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_OPNREQ_TEST/opnReqTest_250759/cpld_bmark_p7_std_base/nems.configure 
109c109
<       start_type = continue
---
>       start_type = startup
[Minsuk.Ji@hfe10 cpld_bmark_p7_rst]$ diff input.nml /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_OPNREQ_TEST/opnReqTest_250759/cpld_bmark_p7_std_base/input.nml 
40c40
<   make_nh = .F.
---
>   make_nh = .true.
64c64
<   na_init = 0
---
>   na_init = 1
76c76
<   external_ic = .F.
---
>   external_ic = .true.
79,80c79,80
<   nggps_ic = .F.
<   mountain = .T.
---
>   nggps_ic = .true.
>   mountain = .false.
95c95
<   warm_start = .T.
---
>   warm_start = .false.
172c172
<   nstf_name    = 2,0,0,0,0
---
>   nstf_name    = 2,1,0,0,0

For cpld_control_c96_p7:

[Minsuk.Ji@hfe12 cpld_control_c96_p7_rst]$ diff model_configure /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_OPNREQ_TEST/opnReqTest_199727/cpld_control_c96_p7_std_base/model_configure 
9c9
< fhrot:                   12
---
> fhrot:                   0
[Minsuk.Ji@hfe12 cpld_control_c96_p7_rst]$ diff nems.configure /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_OPNREQ_TEST/opnReqTest_199727/cpld_control_c96_p7_std_base/nems.configure 
95c95
<       start_type = continue
---
>       start_type = startup
[Minsuk.Ji@hfe12 cpld_control_c96_p7_rst]$ diff input.nml /scratch1/NCEPDEV/stmp2/Minsuk.Ji/FV3_OPNREQ_TEST/opnReqTest_199727/cpld_control_c96_p7_std_base/input.nml 
40c40
<   make_nh = .F.
---
>   make_nh = .true.
64c64
<   na_init = 0
---
>   na_init = 1
76c76
<   external_ic = .F.
---
>   external_ic = .true.
79,80c79,80
<   nggps_ic = .F.
<   mountain = .T.
---
>   nggps_ic = .true.
>   mountain = .false.
95c95
<   warm_start = .T.
---
>   warm_start = .false.
172c172
<   nstf_name    = 2,0,0,0,0
---
>   nstf_name    = 2,1,0,0,0
376c376
<   input_filename = 'r'
---
>   input_filename = 'n'

@JessicaMeixner-NOAA
Copy link
Collaborator

@MinsukJi-NOAA currently if you are running with waves (like in cpld_bmark_p7), we expect the restart test to fail to reproduce.

@MinsukJi-NOAA
Copy link
Contributor Author

@MinsukJi-NOAA currently if you are running with waves (like in cpld_bmark_p7), we expect the restart test to fail to reproduce.

@JessicaMeixner-NOAA Thanks for the clarification.

@JessicaMeixner-NOAA
Copy link
Collaborator

FYI - same for debug right now with waves.

@MinsukJi-NOAA MinsukJi-NOAA mentioned this issue Nov 23, 2021
16 tasks
@MinsukJi-NOAA
Copy link
Contributor Author

#928 merged via #931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants