Decrease the memory usage by MERRA2 for 6 times #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fill out the required information in the PR template, including the relevant PRs that you've made in FV3 or CCPP relating to this change. |
|
Denise, I have just updated the template. Please let me know that I missed
anything.
…On Wed, Nov 10, 2021 at 8:33 AM Denise Worthen ***@***.***> wrote:
Please fill out the required information in the PR template, including the
relevant PRs that you've made in FV3 or CCPP relating to this change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#903 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIIEEFEUDF4Q2TLMTOTULJYBZANCNFSM5HVSQDSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Anning, it looks like this also makes a change in ccpp/physics but I don't see it listed here. It's also really helpful to have the actual link to the issue or PR in the template. You can do that by using the 'insert link' button and then copying the url from the other repo. Or, within the same repo (for example, in FV3), you can just start typing the words "fixes #" and a list of possible issues and PRs will pop-up for you to chose from. Also, can you edit the title of your FV3 PR? It needs to be descriptive of your change and you have "changes made in gitmodules" |
|
Denise, I do not know how to edit the title of my FV3 PR. Could you give
some instructions?
…On Wed, Nov 10, 2021 at 1:58 PM Denise Worthen ***@***.***> wrote:
Anning, it looks like this also makes a change in ccpp/physics but I don't
see it listed here.
It's also really helpful to have the actual link to the issue or PR in the
template. You can do that by using the 'insert link' button and then
copying the url from the other repo. Or, within the same repo (for example,
in FV3), you can just start typing the words "fixes #" and a list of
possible issues and PRs will pop-up for you to chose from.
Also, can you edit the title of your FV3 PR? It needs to be descriptive of
your change and you have "changes made in gitmodules"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#903 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIMZQIL273YL7RNTMS3ULK6FNANCNFSM5HVSQDSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
On the far right side next to the title is a button that says "edit". You can change the title there. |
AnningCheng-NOAA
changed the title
|
Denise, Thank you! I have just changed the title of my PRs.
…On Wed, Nov 10, 2021 at 2:18 PM Denise Worthen ***@***.***> wrote:
On the far right side next to the title is a button that says "edit". You
can change the title there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#903 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMINDOH3UQ2ERAWHN4DLULLARPANCNFSM5HVSQDSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This was referenced Nov 10, 2021
|
Please fix the revision of your fv3 branch. |
climbfuji
reviewed
Nov 18, 2021
|
@climbfuji All the RT passed. Would you please commit CCPP PR#774? Thanks |
Done - new ccpp-physics hash is 27a312c |
climbfuji
reviewed
Nov 18, 2021
climbfuji
requested changes
Nov 18, 2021
junwang-noaa
approved these changes
Nov 18, 2021
climbfuji
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[X ] Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
[ X] This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
[ X] An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
read MERRA2 data for two months instead of 12 months and read in the data in interpolation when needed. The memory usage by MERRA2 decreases 6 times. There is no results change. no library update.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).