Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the memory usage by MERRA2 for 6 times #423

Merged
merged 6 commits into from
Nov 18, 2021

Conversation

AnningCheng-NOAA
Copy link
Contributor

@AnningCheng-NOAA AnningCheng-NOAA commented Nov 10, 2021

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

read 2 month merra2 data instead of 12 months decrease memory usage by 6 times

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? regression tests done in hera
What compilers / HPCs was it tested with? standard compilers in hera
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
Have the ufs-weather-model regression test been run? On what platform? in hera

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. No
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? No
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@AnningCheng-NOAA AnningCheng-NOAA changed the title changes made in .gitmodules Decrease the memory usage by MERRA2 for 6 times Nov 10, 2021
@junwang-noaa
Copy link
Collaborator

Thanks, the fv3atm branch looks correct now.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will approve after regression testing is complete and the submodule pointer was updated.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccpp-physics hash is correct

@AnningCheng-NOAA
Copy link
Contributor Author

AnningCheng-NOAA commented Nov 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants