Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDEPS component and remove DATM component #845

Merged

Conversation

binli2337
Copy link
Contributor

@binli2337 binli2337 commented Oct 1, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

The CDEPS component will be updated to include the latest changes from ESCOMP/CDEPS.
The DATM component will be removed and related scripts and configuration files will also be removed.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • CI: Skip due to DATM submodule related changes in CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@binli2337 binli2337 self-assigned this Oct 1, 2021
@binli2337 binli2337 added the No Baseline Change No Baseline Change label Oct 1, 2021
@binli2337
Copy link
Contributor Author

@junwang-noaa The code is ready.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Oct 15, 2021 via email

@DeniseWorthen
Copy link
Collaborator

There are still some remaining files w/ references to NEMSDatm: cmake/configure_apps.cmake and CMakeLists.txt.

I also think we need to clean up the NEMS/src/module_EARTH_GRID_component, which has both FRONT_NEMS_DATM and FRONT_CDEPS_DATM. This would have required a NEMS PR also.

@DeniseWorthen
Copy link
Collaborator

@binli2337 I've removed the run directory. It isn't actually necessary to delete them before re-running the auto-RT.

@binli2337
Copy link
Contributor Author

@DeniseWorthen Thanks!

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: gnu
Job: RT
Repo location: /glade/scratch/dtcufsrt/autort/tests/auto/pr/747670691/20211015120014/ufs-weather-model
Please manually delete: /glade/scratch/dtcufsrt/FV3_RT/rt_69000
Test control_thompson_extdiag_debug 025 failed failed
Test control_thompson_extdiag_debug 025 failed in run_test failed
Test control_diag_debug 017 failed failed
Test control_diag_debug 017 failed in run_test failed
Please make changes and add the following label back:
cheyenne-gnu-RT

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Oct 15, 2021

The control_thompson_extdiag_debug failure on cheyenne was

77:mp_thompson_post_run: ttendlim applied 1/4064 times at timestep 1
144:
144:Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.
144:
144:Backtrace for this error:
144:#0  0x2b697cd00aff in ???
144:#1  0x10b8723 in ???
144:#2  0x10b78a1 in ???
144:#3  0x10b62fa in ???

I'll try copying the run directory and try re-running.

The control_diag_debug was a time-out.

DeniseWorthen and others added 2 commits October 15, 2021 14:36
* control_thompson_extdiag_debug and control_diag_debug were
re-run manually
@binli2337 binli2337 added the Waiting for Reviews The PR is waiting for reviews from associated component PR's. label Oct 17, 2021
@junwang-noaa
Copy link
Collaborator

@binli2337 cray log file is at: /scratch1/NCEPDEV/stmp2/Jun.Wang/wcosslog/RegressionTests_wcoss_cray.log

@binli2337 binli2337 mentioned this pull request Oct 18, 2021
15 tasks
@DeniseWorthen
Copy link
Collaborator

It looks like CDEPS has been updated, so once the submodule is reverted I will approve.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup work!

@junwang-noaa junwang-noaa merged commit 7d812f9 into ufs-community:develop Oct 18, 2021
@binli2337 binli2337 deleted the cdeps_update_datm_cleanup branch October 26, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CDEPS component to the latest master branch of ESCOMP/CDEPS Remove DATM and related files
8 participants