-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CDEPS component and remove DATM component #845
Update CDEPS component and remove DATM component #845
Conversation
CDEPS points to a recently updated version
revise parm/nems.configure.hafs_atm_docn.IN revise parm/nems.configure.hafs_atm_ocn.IN remove DATM
@junwang-noaa The code is ready. |
I started RT on cray
…On Fri, Oct 15, 2021 at 9:47 AM BinLi-NOAA ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa> The code is ready.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#845 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TPVJDHGHRGPZIFNBODUHAWHLANCNFSM5FE2I7QA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
There are still some remaining files w/ references to NEMSDatm: cmake/configure_apps.cmake and CMakeLists.txt. I also think we need to clean up the NEMS/src/module_EARTH_GRID_component, which has both FRONT_NEMS_DATM and FRONT_CDEPS_DATM. This would have required a NEMS PR also. |
@binli2337 I've removed the run directory. It isn't actually necessary to delete them before re-running the auto-RT. |
@DeniseWorthen Thanks! |
Automated RT Failure Notification |
The control_thompson_extdiag_debug failure on cheyenne was
I'll try copying the run directory and try re-running. The control_diag_debug was a time-out. |
* control_thompson_extdiag_debug and control_diag_debug were re-run manually
@binli2337 cray log file is at: /scratch1/NCEPDEV/stmp2/Jun.Wang/wcosslog/RegressionTests_wcoss_cray.log |
It looks like CDEPS has been updated, so once the submodule is reverted I will approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup work!
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
The CDEPS component will be updated to include the latest changes from ESCOMP/CDEPS.
The DATM component will be removed and related scripts and configuration files will also be removed.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs