Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CCPP standard names for consistency #719

Merged
merged 10 commits into from
Jul 29, 2021
Merged

Update CCPP standard names for consistency #719

merged 10 commits into from
Jul 29, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jul 28, 2021 •
edited
Loading

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • [n/a] If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Description

This PR only updates the submodule pointer for fv3atm for the CCPP standard name updates described in the associated PRs below (in fv3atm and ccpp-physics). No changes to the input data or the results.

Testing

Regression tests are run on all tier-1 platforms against the existing baselines, except Cheyenne (still under maintenance):

Dependencies

NCAR/ccpp-physics#715
NOAA-EMC/fv3atm#356
#719

This was referenced Jul 28, 2021
Merged
Merged
@climbfuji climbfuji added hera-intel-RT No Baseline Change No Baseline Change Waiting for Reviews The PR is waiting for reviews from associated component PR's. labels Jul 28, 2021
@github-actions github-actions bot removed the run-ci label Jul 28, 2021
@github-actions github-actions bot removed the run-ci label Jul 28, 2021
@BrianCurtis-NOAA
Copy link
Collaborator

Machine: orion
Compiler: intel
Job: RT
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/698974631/20210728151511/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_456945
Test cpld_control_c192 006 failed failed
Test cpld_control_c192 006 failed in run_test failed
Test cpld_control_c384 008 failed failed
Test cpld_control_c384 008 failed in run_test failed
Test cpld_bmark_wave_v16 013 failed failed
Test cpld_bmark_wave_v16 013 failed in run_test failed
Test cpld_bmark_v16_nsst 012 failed failed
Test cpld_bmark_v16_nsst 012 failed in run_test failed
Test control_c192 024 failed failed
Test control_c192 024 failed in run_test failed
Test control_wrtGauss_netcdf_parallel 023 failed failed
Test control_wrtGauss_netcdf_parallel 023 failed in run_test failed
Test control_lheatstrg 031 failed failed
Test control_lheatstrg 031 failed in run_test failed
Test control_csawmgt 036 failed failed
Test control_csawmgt 036 failed in run_test failed
Test cpld_bmark_v16 010 failed failed
Test cpld_bmark_v16 010 failed in run_test failed
Test control_c384 025 failed failed
Test control_c384 025 failed in run_test failed
Please make changes and add the following label back:
orion-intel-RT

@climbfuji
Copy link
Collaborator Author

Machine: orion
Compiler: intel
Job: RT
Repo location: /work/noaa/nems/emc.nemspara/autort/pr/698974631/20210728151511/ufs-weather-model
Please manually delete: /work/noaa/stmp/bcurtis/stmp/bcurtis/FV3_RT/rt_456945
Test cpld_control_c192 006 failed failed
Test cpld_control_c192 006 failed in run_test failed
Test cpld_control_c384 008 failed failed
Test cpld_control_c384 008 failed in run_test failed
Test cpld_bmark_wave_v16 013 failed failed
Test cpld_bmark_wave_v16 013 failed in run_test failed
Test cpld_bmark_v16_nsst 012 failed failed
Test cpld_bmark_v16_nsst 012 failed in run_test failed
Test control_c192 024 failed failed
Test control_c192 024 failed in run_test failed
Test control_wrtGauss_netcdf_parallel 023 failed failed
Test control_wrtGauss_netcdf_parallel 023 failed in run_test failed
Test control_lheatstrg 031 failed failed
Test control_lheatstrg 031 failed in run_test failed
Test control_csawmgt 036 failed failed
Test control_csawmgt 036 failed in run_test failed
Test cpld_bmark_v16 010 failed failed
Test cpld_bmark_v16 010 failed in run_test failed
Test control_c384 025 failed failed
Test control_c384 025 failed in run_test failed
Please make changes and add the following label back:
orion-intel-RT

Seems like these tests timed out. I am on orion now, the file system response is really, really slow. Will try to run again manually, but since the filesystem is still slow I guess we will have timeouts again.

@climbfuji
Copy link
Collaborator Author

orion.intel done at last - we can start the merge process

@climbfuji climbfuji mentioned this pull request Jul 29, 2021
Open
@climbfuji climbfuji added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Jul 29, 2021
@climbfuji
Copy link
Collaborator Author

Ready to merge, please check again and click the magic button. Thanks!

@junwang-noaa junwang-noaa merged commit 200315b into ufs-community:develop Jul 29, 2021
junwang-noaa pushed a commit that referenced this pull request Sep 3, 2021
@aerorahul
update templates for diag_table to be consistent with model_configure (…
77eaba8 
…#781)

* update templates for diag_table to be consistent with model_configure
* remove edit_diag_table function. point to @climbfuji branch of FV3atm
* FV3 is updated with land mask bug fix (CCPP issue #719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

Assignees
No one assigned
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@climbfuji @BrianCurtis-NOAA @junwang-noaa @DusanJovic-NOAA @MinsukJi-NOAA