release/public-v2: noahmp_bugfix

[llpcarson]

Description

(1) Some updates to prevent the model from crashing.
(2) Include opt_stc=3 bug fix in both noahmp land and glacier code (no initialization for some parameters)
(3) The wrong downward longwave forcing to Noah MP. Noah MP expects the
downward longwave before surface emission, however the current driver passed the
one after emission. Inside Noah MP it is multiplied by surface emissivity
again. So generally Noah MP is getting less downward longwave.

Issue(s) addressed

NCAR/ccpp-physics#556

Testing

RT completed for cheyenne.intel, cheyenne.gnu and hera.intel
Baseline changed for all tests using NOAH-MP (control, RRFS)
New baselines are:
hera.intel: /scratch1/BMC/gmtb/stmp4/Laurie.Carson/FV3_RT/REGRESSION_TEST_RELEASE_PUBLIC_V2_INTEL/
cheyenne.intel: /glade/work/carson/FV3_RT/REGRESSION_TEST_RELEASE_PUBLIC_V2_INTEL
cheyenne.gnu: /glade/work/carson/FV3_RT/REGRESSION_TEST_RELEASE_PUBLIC_V2_GNU

Dependencies

• waiting on Public release v5 noahmp bugfix NCAR/ccpp-physics#557
• waiting on release/public-v2: noahmp_bugfix NOAA-EMC/fv3atm#240

[climbfuji]

@llpcarson I assume I should copy the baselines you created into the final location. Can you change the date tag in rt.sh (RTPWD) please? Shall we use 20210126? I will run the regression tests on the three systems afterwards to verify that everything is in the right place, and I will create baselines on the other platforms, too. Thanks!

[llpcarson]

Done, thanks! Let me know if there are any permissions issues.

[climbfuji]

@llpcarson please copy all log files from cheyenne for this PR. I reran the tests on cheyenne and hera after moving the data:

heinzell@cheyenne1:/glade/work/heinzell/fv3/ufs-weather-model/ufs-weather-model-public_release_v5_noahmp_bugfix/gnu/tests [gnu|P48503002]> ls -l /glade/work/heinzell/fv3/ufs-weather-model/ufs-weather-model-public_release_v5_noahmp_bugfix/logs_for_laurie/
total 192
-rw-r--r-- 1 heinzell ncar 26635 Jan 27 08:19 RegressionTests_cheyenne.gnu.log
-rw-r--r-- 1 heinzell ncar 26661 Jan 27 08:19 RegressionTests_cheyenne.intel.log
-rw-r--r-- 1 heinzell ncar 26551 Jan 27 10:55 RegressionTests_gaea.intel.log
-rw-r--r-- 1 heinzell ncar 26791 Jan 27 14:16 RegressionTests_hera.gnu.log
-rw-r--r-- 1 heinzell ncar 26564 Jan 27 09:00 RegressionTests_hera.intel.log
-rw-r--r-- 1 heinzell ncar 26512 Jan 27 14:17 RegressionTests_jet.intel.log

Thanks!

[llpcarson]

Done

…

On Wed, Jan 27, 2021 at 2:19 PM Dom Heinzeller ***@***.***> wrote: @llpcarson <https://github.com/llpcarson> please copy all log files from cheyenne for this PR. I reran the tests on cheyenne and hera after moving the data: ***@***.***:/glade/work/heinzell/fv3/ufs-weather-model/ufs-weather-model-public_release_v5_noahmp_bugfix/gnu/tests [gnu|P48503002]> ls -l /glade/work/heinzell/fv3/ufs-weather-model/ufs-weather-model-public_release_v5_noahmp_bugfix/logs_for_laurie/ total 192 -rw-r--r-- 1 heinzell ncar 26635 Jan 27 08:19 RegressionTests_cheyenne.gnu.log -rw-r--r-- 1 heinzell ncar 26661 Jan 27 08:19 RegressionTests_cheyenne.intel.log -rw-r--r-- 1 heinzell ncar 26551 Jan 27 10:55 RegressionTests_gaea.intel.log -rw-r--r-- 1 heinzell ncar 26791 Jan 27 14:16 RegressionTests_hera.gnu.log -rw-r--r-- 1 heinzell ncar 26564 Jan 27 09:00 RegressionTests_hera.intel.log -rw-r--r-- 1 heinzell ncar 26512 Jan 27 14:17 RegressionTests_jet.intel.log Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2OWIVLZSMA37OXLM37H3TS4B7NXANCNFSM4WSRS4AA> .

[climbfuji]

Done
…

Great - last bit, update of the fv3atm submodule pointer and reversal of the .gitmodules change, please.

[llpcarson]

OK, done, thanks for your help!

…

On Wed, Jan 27, 2021 at 2:39 PM Dom Heinzeller ***@***.***> wrote: Done … <#m_-2805396414460972905_> Great - last bit, update of the fv3atm submodule pointer and reversal of the .gitmodules change, please. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#393 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2OWIWB6M3JVG4HUCYH72TS4CBY3ANCNFSM4WSRS4AA> .

[climbfuji]

Thanks for making those changes!