release/public-v2: noahmp_bugfix #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llpcarson
changed the title
This was referenced Jan 25, 2021
climbfuji
approved these changes
Jan 27, 2021
|
@junwang-noaa @DusanJovic-NOAA can one of you please merge this PR? Thanks! |
junwang-noaa
approved these changes
Jan 27, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(1) Some updates to prevent the model from crashing.
(2) Include opt_stc=3 bug fix in both noahmp land and glacier code (no initialization for some parameters)
(3) The wrong downward longwave forcing to Noah MP. Noah MP expects the
downward longwave before surface emission, however the current driver passed the
one after emission. Inside Noah MP it is multiplied by surface emissivity
again. So generally Noah MP is getting less downward longwave.
Issue(s) addressed
NCAR/ccpp-physics#556
Testing
See details at: https://github.com/ufs-weather-model/pull/393
Dependencies