-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufs_public_release: updates from DTC and GSD, namelists for GFSv15.2 and GFSv16beta, update FMS submodule pointer #15
Conversation
Associated PRs: For regression testing, see below. |
Manual testing on macOS+GNU: code compiles and gives b4b identical results between IPD, CCPP dynamic and CCPP static in REPRO mode for fv3_gfdlmp / fv3_ccpp_gfdlmp. |
Follow-up commits to this PR will modify the regression test config Original
This is expected, because the updates to the GSD suite and the bugfix for the NoahMP precipitation rates are changing the answer. rt_full.log
Update 2019/12/14: I reran the |
Regression testing using new rt.conf on Cheyenne with Intel GNU successful - first create new baseline, then rsync to final RTPWD, then test against RTPWD. Regression test logs have been updated in the repository. rt_gnu_create.log |
(2) Add -Wall to compiler flags for GNU compilers (3) Update ESMF version for modulefiles/gaea.intel/fv3.intel-16.0.3.210 (4) Change default queue to economy on Cheyenne, remove warnings for non-existent include directories for GNU compiler
…modules for code review process
…n_test.sh (2) New regression tests fv3_ccpp_gfs_v15p2, fv3_ccpp_gfs_v15p2_debug, fv3_ccpp_gfs_v16beta, fv3_ccpp_gfs_v16beta_debug (3) Update of rt.conf to run only those tests, update of RTPWD in rt.sh (4) Bugfixes for regression testing system using new compile_cmake.sh, compile_cmake configuration for cheyenne.{intel,gnu}
b3d3950
to
8cabcd7
Compare
@junwang-noaa @DusanJovic-NOAA @arunchawla-NOAA @ligiabernardet I fixed the .gitmodules typo that Dusan mentioned. I also updated the pull requests based on the conversation we had earlier this morning to minimize the changes in fv3atm and ufs-weather-model. I reran the regression tests for the two new tests and updated the regression test logs against the new baseline directory ufs-public-release-20191212 (on hera.intel, cheyenne.intel, cheyenne.gnu). I am also rerunning this against the previous baseline trunk-20191021 to make sure that the differences I get are the same than before the latest round of updates (i.e. only NoahMP and GSD physics) - just to make sure that everything is correct. Thanks for your patience! |
…revert change in .gitmodules
8cabcd7
to
1385c1e
Compare
Default ccpp suite in build.sh is set to FV3_GFS_2017_gfdlmp (CCPP_SUITES variable). SDF for FV3_GFS_2017_gfdlmp is removed from fv3atm/ccpp/suties. Which suite should be new default? |
Only two to choose from! I would say GFSv15p2, but I would be ok with GFSv16beta as well. Jun, Arun? |
…e default suite in build.sh
Correction: Diag%hpbl => Tbd%hpbl
…munity#27) * add fh00 post control file, add restart output at specified forecast hours, ugwd bug fixes * fv3atm ufs-community#15:Add support for GEFS-Aerosols restart capability * remove comment prints * fix RunDuration in atmos fcst side * update post_gfs with new post changes * comment out print line * point fv3 dycore to the latest NOAA-EMC dev/emc branch
* Update InputsOutputs.rst, Codeoverview * Stampede update (#15) * Fix build env setup in Chapter 3 (#16) * cleanup and reorg of 2.2 Directory Structure Co-authored-by: BinLi-NOAA <[email protected]> Co-authored-by: jiandewang <[email protected]> Co-authored-by: Ali.Abdolali <[email protected]> Co-authored-by: Ali Abdolali <[email protected]> Co-authored-by: Jun Wang <[email protected]> Co-authored-by: Minsuk Ji <[email protected]>
Merge GFDL new dynamic core 201912 release version to dev/emc.
* Added build support on Odin and Stampede * Updated Externals.cfg for Stampede/Odin updates
…update_150 Update ufs_acorn.intel.lua for spack-stack 1.5.0
This PR contains: