Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ufs_public_release: updates from DTC (bugfixes, cleanup, optimization) #245

Merged
merged 3 commits into from
Dec 16, 2019
Merged

ufs_public_release: updates from DTC (bugfixes, cleanup, optimization) #245

merged 3 commits into from
Dec 16, 2019

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 10, 2019 •
edited
Loading

This PR contains:

  • bugfix Develop #2 for travis test in schemes/check/ccpp_prebuild_config.py
  • optimization/cleanup: only compile the files that are needed when static build is selected
  • improved handling of builddir/basedir argument to ccpp_prebuild.py and metadata2html.py
  • improved error handling and diagnostic output for ccpp_prebuild.py

climbfuji and others added 3 commits November 1, 2019 06:59
@climbfuji
Merge pull request NCAR#236 from climbfuji/travis_bugfix_2_20191101
28fdede 
Bugfix #2 for travis test in schemes/check/ccpp_prebuild_config.py
@climbfuji
Optimization/cleanup: only compile the files that are needed when sta…
4c9389d 
…tic build is selected
@climbfuji
Improved handling of builddir/basedir argument to ccpp_prebuild.py an…
10f8501 
…d metadata2html.py, improved error handling and diagnostic output for ccpp_prebuild.py
This was referenced Dec 10, 2019
Merged
Merged
@climbfuji
Copy link
Collaborator Author

Associated PRs:
NOAA-PSL/stochastic_physics#7
#245
NCAR/ccpp-physics#369
NOAA-EMC/fv3atm#22
ufs-community/ufs-weather-model#15

For regression testing, see ufs-community/ufs-weather-model#15

This was referenced Dec 10, 2019
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review December 10, 2019 22:33
grantfirl
grantfirl approved these changes Dec 13, 2019
View reviewed changes
Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@climbfuji climbfuji merged commit 009f905 into NCAR:ufs_public_release Dec 16, 2019
@climbfuji climbfuji deleted the ufs_public_release_update_from_dtc_20191210 branch June 27, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfirl grantfirl grantfirl approved these changes

@tanyasmirnova tanyasmirnova tanyasmirnova approved these changes

@llpcarson llpcarson Awaiting requested review from llpcarson

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@climbfuji @grantfirl @tanyasmirnova