Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline post for RRFS and HAFS #1360

Merged
merged 14 commits into from
Aug 18, 2022

Conversation

WenMeng-NOAA
Copy link
Contributor

@WenMeng-NOAA WenMeng-NOAA commented Jul 30, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

This PR will update FV3 component for inline post changes:

  • Output lat/lon of four corner points in text file for RRFS rotated lat-lon gird

  • Read instant model top longwave from model

  • Update upp submodule revision with the recent commits from UPP repository.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

Testing

How were these changes tested? Yes. What compilers / HPCs was it tested with? Intel on WCOSS2. Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes. Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@jkbk2004
Copy link
Collaborator

@WenMeng-NOAA We can start working on this PR. Can you sync up to develop branch? Since change is on write grid component, do we expect baseline will change?

@DeniseWorthen
Copy link
Collaborator

@WenMeng-NOAA I see that you checked the box that baselines will change for one or more test. But I don't see that you've added information about the testing. Have you tested this PR yet on any platform to verify which tests change and that all tests run to completion?

@WenMeng-NOAA
Copy link
Contributor Author

@DeniseWorthen That's my early testing. After the PR #1305 committed, there should be no baseline changed in the UFS RT test from my testing on WCOSS2 last week. I will revert that check box. Thanks!

@WenMeng-NOAA
Copy link
Contributor Author

@WenMeng-NOAA We can start working on this PR. Can you sync up to develop branch? Since change is on write grid component, do we expect baseline will change?

Will do it. There should be no baseline changed in my PR now.

Solved FV3 conflict and point to my branch with revision 68cc00a.
@WenMeng-NOAA
Copy link
Contributor Author

@jkbk2004 My UFS branch and FV3 branch are up to date now. Please let me know if any actions are needed from my end. Thanks!

@jkbk2004
Copy link
Collaborator

Thanks for the information! I will go ahead to start testing on hera/intel/gnu first.

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: intel
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/1012916008/20220816191508/ufs-weather-model
[RT] Error: Test datm_cdeps_mx025_cfsr 141 failed in run_test failed
Please make changes and add the following label back: hera-intel-RT

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: RT
[RT] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1012916008/20220816221515/ufs-weather-model
[RT] Error: Test control_ras 071 failed in run_test failed
[RT] Error: Test hafs_regional_atm_wav 115 failed in run_test failed
Please make changes and add the following label back: jet-intel-RT

@jkbk2004
Copy link
Collaborator

@WenMeng-NOAA merged the fv PR. Can you revert gitmodule branch pointer and update fv3 submodule pointer?

@WenMeng-NOAA
Copy link
Contributor Author

@WenMeng-NOAA merged the fv PR. Can you revert gitmodule branch pointer and update fv3 submodule pointer?

@jkbk2004 Done.

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hashes are correct.

@jkbk2004 jkbk2004 self-requested a review August 18, 2022 17:28
@jkbk2004 jkbk2004 merged commit 4640a44 into ufs-community:develop Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update inline post for two requests from RRFS and HAFS
4 participants