Add esmf managed threading test and fix inline post issues in P8 #1305
Conversation
…T testing infrastructure. First test case: cpld_esmfthreads_p8.
|
@junwang-noaa I see that the PR indicates "1 unresolved conversation". However, I cannot figure out how to mark it resolved. I just want to make sure this PR isn't hanging there for an odd technicality. Thanks. |
1 similar comment
|
@junwang-noaa I see that the PR indicates "1 unresolved conversation". However, I cannot figure out how to mark it resolved. I just want to make sure this PR isn't hanging there for an odd technicality. Thanks. |
|
The code is updated with the comments. Now it is resolved. |
|
Why is the merge still blocked? Dusan and myself have approved, and it looks like 2 approving reviews are required. |
1 similar comment
|
Why is the merge still blocked? Dusan and myself have approved, and it looks like 2 approving reviews are required. |
|
We need two code managers to approve it. Also we have several commits before this PR, I will keep updating the branch. |
|
Got it. Thank you. |
|
Sorry the inline post change was not kept during the merge this morning. I
just updated the code.
…On Fri, Aug 5, 2022 at 1:53 PM Brian Curtis ***@***.***> wrote:
*Automated RT Failure Notification*
Machine: hera
Compiler: intel
Job: BL
[BL] Repo location:
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/984370435/20220805140012/ufs-weather-model
[BL] Baseline creation and move successful
[RT] Repo location:
/scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/984370435/20220805163507/ufs-weather-model
[RT] Error: Test cpld_restart_bmark_p8 011 failed in check_result failed
[RT] Error: Test cpld_restart_bmark_p8 011 failed in run_test failed
Please make changes and add the following label back: hera-intel-BL
—
Reply to this email directly, view it on GitHub
<#1305 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TI4IVGUAMOFXB6W4A3VXVIKTANCNFSM52K64ZIA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sure! I will catch up with tests. |
|
Automated RT Failure Notification |
|
Automated RT Failure Notification |
|
cpld_bmark_p8 and cpld_bmark_esmfthreads_p8 crash on cheyenne/intel: MPT ERROR: Rank 570(g:570) received signal SIGSEGV(11) and MPT: shepherd terminated. For cpld_bmark_p8, I double checked with develop branch and the develop branch ran ok. I tried esmf-8.4.0b08 but it seems like there is still pio issue. I used pio-2.5.7/esmf-8.4.0b08. Build doesn't go thru on cheyenne/intel/mpt. Do you think it might be worth to try another version of emsf like 8.3.1 or so? |
|
cpld_bmark_p8 cheyenne/gnu crashes as well. |
|
@jkbk2004 There is no change on the pio/ESMF library in this PR. Since we turned on inline post, can you increase the write tasks per group to see if that can be an issue? I don't think we can run cpld_bmark_p8 (S2SWA) with gnu yet. |
|
all tests passed. we can move on for merging in the pr. @DeniseWorthen @ChunxiZhang-NOAA will you leave final comments and move for approval? @junwang-noaa I am moving to fv3atm pr#569. |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
This PR will add two ESMF managed threading tests in the UFS WM coupled test. Also ESMF profile setting is added the job_card to help tracking the computational performance.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs