Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes that broke the restart reproducible for fractional grid #286

Closed
ShanSunNOAA opened this issue Nov 18, 2020 · 0 comments · Fixed by #304
Closed

Bug fixes that broke the restart reproducible for fractional grid #286

ShanSunNOAA opened this issue Nov 18, 2020 · 0 comments · Fixed by #304
Assignees
@ShanSunNOAA
Labels
bug Something isn't working

Comments

@ShanSunNOAA
Copy link
Collaborator

In FV3GFS_io.F90, when the fractional grid is used, it filters out bad water temperature in the initial conditions if it is below freezing. This would filter out bad water temperature in the restart stage as well, breaking the reproducibility after restart.

I suggest using this filter at the initial starting time only, since restart should be a data-read-in process, and not filter out unrealistic values occasionally generated in the model for some reasons.
@ShanSunNOAA ShanSunNOAA added the bug Something isn't working label Nov 18, 2020
ShanSunNOAA added a commit to ShanSunNOAA/ufs-weather-model that referenced this issue Nov 19, 2020
@ShanSunNOAA
-- Adding benchmark tests for the fractional grid. The earlier crash …
97bc7e7 
…was fixed by Moorthi's modifications in ccpp/physics;

-- Restart in the coupled mode with the default physics is reproducible, if (1) bad water temperature is only filtered at the initial time; (2) no longer initialize fice to zero everywhere in the FV3 cap in order to leave lake ice untouched;

These are for Issues ufs-community#285 & ufs-community#286.

Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
ShanSunNOAA added a commit to ShanSunNOAA/ufs-weather-model that referenced this issue Nov 19, 2020
@ShanSunNOAA
-- Adding benchmark tests for the fractional grid. The earlier crash …
04c6dfd 
…was fixed by Moorthi's modifications in ccpp/physics;

-- Restart in the coupled mode with the default physics is reproducible, when
   (1) bad water temperature is only filtered at the initial time;
   (2) stop initializing fice to zero everywhere in the FV3 cap in order to keep lake ice untouched;

    These address Issues ufs-community#268, ufs-community#285 & ufs-community#286.

    Co-authored-by: Shrinivas Moorthi <[email protected]>
    Co-authored-by: Denise Worthen <[email protected]>
@climbfuji climbfuji mentioned this issue Dec 1, 2020
Merged
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this issue Jul 20, 2021
@DusanJovic-NOAA
Use OPENMP instead of OpenMP_Fortran_FOUND, cleanup compiler flags (u…
bfb8da5 
…fs-community#286)

* Simplify ccpp/data/CMakeLists.txt and ccpp/driver/CMakeLists.txt
* Use OPENMP instead of OpenMP_Fortran_FOUND
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanSunNOAA ShanSunNOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@ShanSunNOAA