Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a benchmark test case for the fractional grid #285

Closed
ShanSunNOAA opened this issue Nov 18, 2020 · 0 comments · Fixed by #354
Closed

Adding a benchmark test case for the fractional grid #285

ShanSunNOAA opened this issue Nov 18, 2020 · 0 comments · Fixed by #354
Assignees
@ShanSunNOAA
Labels
enhancement New feature or request

Comments

@ShanSunNOAA
Copy link
Collaborator

(1) Creating a fractional test "cpld_bmark_wave_frac" based on the existing "cpld_bmark_wave".
(2) Additional initial conditions needed for this test will be added as well.
@ShanSunNOAA ShanSunNOAA added the enhancement New feature or request label Nov 18, 2020
ShanSunNOAA added a commit to ShanSunNOAA/ufs-weather-model that referenced this issue Nov 19, 2020
@ShanSunNOAA
-- Adding benchmark tests for the fractional grid. The earlier crash …
97bc7e7 
…was fixed by Moorthi's modifications in ccpp/physics;

-- Restart in the coupled mode with the default physics is reproducible, if (1) bad water temperature is only filtered at the initial time; (2) no longer initialize fice to zero everywhere in the FV3 cap in order to leave lake ice untouched;

These are for Issues ufs-community#285 & ufs-community#286.

Co-authored-with: Shrinivas Moorthi <[email protected]>
Co-authored-with: Denise Worthen <[email protected]>
ShanSunNOAA added a commit to ShanSunNOAA/ufs-weather-model that referenced this issue Nov 19, 2020
@ShanSunNOAA
-- Adding benchmark tests for the fractional grid. The earlier crash …
04c6dfd 
…was fixed by Moorthi's modifications in ccpp/physics;

-- Restart in the coupled mode with the default physics is reproducible, when
   (1) bad water temperature is only filtered at the initial time;
   (2) stop initializing fice to zero everywhere in the FV3 cap in order to keep lake ice untouched;

    These address Issues ufs-community#268, ufs-community#285 & ufs-community#286.

    Co-authored-by: Shrinivas Moorthi <[email protected]>
    Co-authored-by: Denise Worthen <[email protected]>
This was referenced Dec 7, 2020
Closed
Closed
@DeniseWorthen DeniseWorthen mentioned this issue Jan 4, 2021
Merged
@DeniseWorthen DeniseWorthen linked a pull request Jan 5, 2021 that will close this issue
add frac grid input, update and add additional cpld tests #354
Merged
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this issue Jul 20, 2021
@climbfuji
Move sfc emis alb calculation to its own scheme and make z0 composite…
ba7943e 
… consistent (ufs-community#285)

   - Update all suite definition files with the new CCPP scheme GFS_radiation_surface
    - Add new arrays for surface albedo and surface emissivity to GFS_typedefs.F90 and to FV3GFS_io.F90
    - Update FV3GFS_io.F90 to write out composite tsfc and zorl for restarts, simplify logic for these two fields
    - Unrelated change: fix a bug when MULTIGASES physics option is set: correctly allocate the rilist and cpilist arrays
    - Unrelated change: remove cnvc90 from ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml
    - Rename suite FV3_GFS_v16b_ugwpv1 to FV3_GFS_v16_ugwpv1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanSunNOAA ShanSunNOAA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add frac grid input, update and add additional cpld tests DeniseWorthen/ufs-weather-model
1 participant
@ShanSunNOAA