-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Add restart capability to forecast task #682
[develop] Add restart capability to forecast task #682
Conversation
…weather-app into feature/aqm_restart
…er-app into feature/aqm_restart
… into feature/aqm_restart
…her-app into feature/aqm_restart
@JeffBeck-NOAA, it works well !!! Thank you for your suggestion and I am sorry again for my late understanding! I am running a couple of WE2E tests now. |
@chan-hoo, excellent! Glad to hear things are running well and no problem! |
@MichaelLueken, the latest change passed three WE2E tests for FV3_GFS_v16, FV3_GFS_v17_p8, and FV3_GFS_v15p2 (w/ GSMGFS). Could you check the results of the Jenkins test? |
@chan-hoo Thank you for working with @JeffBeck-NOAA with respect to nstf_name and NSST spin-up issues! I have resubmitted the Jenkins tests for this PR. There are still issues with the Jenkins tests following Friday's migration to a new site, so I will let you know if there are any new failures. |
@chan-hoo The Jenkins tests have passed. I'm in the middle of manually rerunning the tests on Jet now. I'll update the PR once the Jet tests are complete. |
@chan-hoo The manual WE2E fundamental tests on Jet have successfully passed. I have also spoken with @christinaholtNOAA. We are hoping to get her PR in tomorrow or early on Friday. If there are issues with the Jenkins testing or manual tests on Jet, then I will be able to move forward with these changes. Thank you! |
@MichaelLueken, can you merge this PR first? I'd like to create a production branch for AQM from this PR without @christinaholtNOAA's PR. |
@chan-hoo Unfortunately, this PR will only be able to be merged before @christinaholtNOAA's PR if there are still issues with her PR. If you don't want to include @christinaholtNOAA's PR in the production branch for |
@MichaelLueken, no problem. Will do. |
@MichaelLueken, you can merge this PR although I found some bugs on WCOSS2 and AQM configuration caused by PR #676 (Issues #709 and #710). I hope @christinaholtNOAA will resolve them soon. This PR itself doesn't show any issues on Hera. |
@chan-hoo From @christinaholtNOAA's discussion in issue #709, it sounds like she has a fix for several issues. I will hold off on merging this work until both of you have decided the best path to get the updates in (either through this PR or in a separate PR). Having said that, I have rerun the Jenkins tests after you updated your branch to the latest develop and all tests successfully passed. So, these changes are ready to go either now, or after merging Christina's changes in. |
@MichaelLueken, Can you merge this PR? There are so many issues to be resolved for AQM now, so I think it would be better to open a separate PR for them. I'll have to review and merge the PR #708 for the AQM implementation first. |
DESCRIPTION OF CHANGES:
DO_FCST_RESTART
turning on/off the restart option of the forecast task.update_restart_input_nml_file.py
replacing the six parameters related to the restart option in the FV3 input.nml file.fhrot
to model_configure.model_configure
andnems.configure
with the latest format.Type of change
TESTS CONDUCTED:
-a
argument:rocotorewind
for the forecast task:phyf004-006.nc
anddynf004-006.nc
files are produced again.ISSUE:
Fixes issue mentioned in #681
DEPENDENCIES:
PR #663
CHECKLIST
CONTRIBUTORS:
RatkoVasic-NOAA