Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to read soil increments on the cubed-sphere tiles and enhance soil ice adjustment due to soil temperature increments #894

Merged
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5c763f2
clean up & reorganize based on reviews
yuanxue2870 Feb 7, 2024
f65d8fa
Delete unit test data/ from Github
yuanxue2870 Feb 9, 2024
db18a1d
Delete unit test data
yuanxue2870 Feb 9, 2024
f709f7c
Delete unit test data
yuanxue2870 Feb 9, 2024
f6c9038
Delete unit test data
yuanxue2870 Feb 9, 2024
e731a85
Delete unit test data
yuanxue2870 Feb 9, 2024
a8daad2
Delete unit test data
yuanxue2870 Feb 9, 2024
0bacd5a
obtain unit test data from server with updated unit test
yuanxue2870 Feb 14, 2024
84b075e
Merge branch 'feature/soil_ice_adjust' of https://github.com/yuanxue2…
yuanxue2870 Feb 14, 2024
89ae1fe
updated driver scripts and revert build and mpiexec back to develop v…
yuanxue2870 Feb 16, 2024
a42b310
updated directories for baseline and unit test data
yuanxue2870 Feb 22, 2024
859f1c0
Updated comments & updated wcoss2 driver
yuanxue2870 Feb 24, 2024
2fcb836
add the prefix of 'snow_' to xainc files
yuanxue2870 Feb 24, 2024
eb1c838
add DO_SOI_INC_GSI & remove GSI_SOI_FILE in the namelist
yuanxue2870 Feb 25, 2024
c2666f8
updated global_cycle driver to avoid editing filenames in source code
yuanxue2870 Feb 26, 2024
ad37694
add lsoil_incr to namelist and set to 3 as default value
yuanxue2870 Feb 26, 2024
81779a6
modified comments on lsoil_incr
yuanxue2870 Mar 6, 2024
b02e4a6
separate gsi based interpolation routine and combine add_gsi and add_…
yuanxue2870 Mar 7, 2024
01b5a99
Merge remote-tracking branch 'remotes/origin/develop' into feature/so…
yuanxue2870 Mar 22, 2024
921c835
revisions due to new JEDI derived (mimicked) soil increment test files
yuanxue2870 Apr 3, 2024
28a8cef
edits to link unit test files from public host
yuanxue2870 Apr 9, 2024
98b3c19
Merge branch 'ufs-community:develop' into feature/soil_ice_adjust
yuanxue2870 Apr 17, 2024
529e7e2
add options in the prolog
yuanxue2870 Apr 17, 2024
d04da42
Merge branch 'ufs-community:develop' into feature/soil_ice_adjust
yuanxue2870 Apr 19, 2024
e3a9149
add gaussian_interp output to nccmp with baseline
yuanxue2870 Apr 19, 2024
afdd2a9
Merge branch 'ufs-community:develop' into feature/soil_ice_adjust
yuanxue2870 May 2, 2024
1588668
revert to defaulted account name
yuanxue2870 May 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export OCNRES=99999

export COMIN=$HOMEreg/input_data_noahmp

export LND_SOI_FILE=$COMIN/sfcincr_gsi
export GSI_SOI_FILE=$COMIN/sfcincr_gsi

export JCAP=1534
export LONB=3072
Expand All @@ -51,7 +51,7 @@ $BASE_GSM/ush/global_cycle_driver.sh
iret=$?
if [ $iret -ne 0 ]; then
set +x
echo "<<< C192 LANDINC SOIL NOAHMP CYCLE TEST FAILED. >>>"
echo "<<< C192 GSI based LANDINC SOIL NOAHMP CYCLE TEST FAILED. >>>"
exit $iret
fi

Expand All @@ -62,7 +62,7 @@ for files in *tile*.nc
do
if [ -f $files ]; then
echo CHECK $files
$NCCMP -dmfqS $files $HOMEreg/baseline_data/c192.lndincsoilnoahmp/$files
$NCCMP -dmfqS $files $HOMEreg/baseline_data/c192.gsi_lndincsoilnoahmp/$files
iret=$?
if [ $iret -ne 0 ]; then
test_failed=1
Expand All @@ -74,15 +74,15 @@ set +x
if [ $test_failed -ne 0 ]; then
echo
echo "**********************************************"
echo "<<< C192 LANDINC SOIL-NOAHMP CYCLE TEST FAILED. >>>"
echo "<<< C192 GSI based LANDINC SOIL-NOAHMP CYCLE TEST FAILED. >>>"
echo "**********************************************"
if [ "$UPDATE_BASELINE" = "TRUE" ]; then
$BASE_GSM/reg_tests/update_baseline.sh $HOMEreg "c192.lndincsoilnoahmp" $commit_num
$BASE_GSM/reg_tests/update_baseline.sh $HOMEreg "c192.gsi_lndincsoilnoahmp" $commit_num
fi
else
echo
echo "*****************************************"
echo "<<< C192 LANDINC SOIL-NOAHMP CYCLE TEST PASSED. >>>"
echo "<<< C192 GSI based LANDINC SOIL-NOAHMP CYCLE TEST PASSED. >>>"
echo "*****************************************"
fi

Expand Down
89 changes: 89 additions & 0 deletions reg_tests/global_cycle/C192.jedi_lndincsoilnoahmp.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
#!/bin/bash

#------------------------------------------------------------------
# Run global_cycle for a C192 case to test the ingest and
# application of soil moisture and temperature increments
# on the cubed-sphere grid into Noah-MP restarts, which should
# yield identical results as compared with the GSI case.
# Compare output to a baseline set of files using the 'nccmp'
# utility.
#------------------------------------------------------------------

set -x

NCCMP=${NCCMP:-$(which nccmp)}

export MAX_TASKS_CY=6

export HOMEgfs=$NWPROD
export BASE_GSM=$NWPROD

export CYCLEXEC=$BASE_GSM/exec/global_cycle

export CDATE=2019073000
export FHOUR=00
export DELTSFC=6

export CASE=C192
export OCNRES=99999

export COMIN=$HOMEreg/input_data_noahmp

export JCAP=1534
export LONB=3072
export LATB=1536

export OROFIX=$HOMEreg/fix/$CASE
export FIXgsm=$BASE_GSM/fix/am

export DONST="NO"
export use_ufo=.true.

export DO_SFCCYCLE=".FALSE."
export DO_LNDINC=".TRUE."
export DO_SOI_INC_JEDI=".true."

export VERBOSE=YES
export CYCLVARS=FSNOL=-2.,FSNOS=99999.,

$BASE_GSM/ush/global_cycle_driver.sh

iret=$?
if [ $iret -ne 0 ]; then
set +x
echo "<<< C192 JEDI based LANDINC SOIL NOAHMP CYCLE TEST FAILED. >>>"
exit $iret
fi

test_failed=0

cd $DATA
for files in *tile*.nc
do
if [ -f $files ]; then
echo CHECK $files
$NCCMP -dmfqS $files $HOMEreg/baseline_data/c192.jedi_lndincsoilnoahmp/$files
iret=$?
if [ $iret -ne 0 ]; then
test_failed=1
fi
fi
done

set +x
if [ $test_failed -ne 0 ]; then
echo
echo "**********************************************"
echo "<<< C192 JEDI based LANDINC SOIL-NOAHMP CYCLE TEST FAILED. >>>"
echo "**********************************************"
if [ "$UPDATE_BASELINE" = "TRUE" ]; then
$BASE_GSM/reg_tests/update_baseline.sh $HOMEreg "c192.jedi_lndincsoilnoahmp" $commit_num
fi
else
echo
echo "*****************************************"
echo "<<< C192 JEDI based LANDINC SOIL-NOAHMP CYCLE TEST PASSED. >>>"
echo "*****************************************"
fi

exit
3 changes: 2 additions & 1 deletion reg_tests/global_cycle/C768.lndincsnow.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ export FNSNOA=$COMIN/gdas.t00z.snogrb_t1534.3072.1536
export FNACNA=$COMIN/gdas.t00z.seaice.5min.blend.grb
export NST_FILE=$COMIN/gdas.t00z.dtfanl.nc

export DO_SNO_INC=.true. # must be lower-case.
export DO_SNO_INC_JEDI=.true. # must be lower-case.
export DO_SOI_INC_JEDI=.false.
export JCAP=1534
export LONB=3072
export LATB=1536
Expand Down
14 changes: 10 additions & 4 deletions reg_tests/global_cycle/driver.hera.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module list

WORK_DIR="${WORK_DIR:-/scratch2/NCEPDEV/stmp1/$LOGNAME}"

PROJECT_CODE="${PROJECT_CODE:-fv3-cpu}"
PROJECT_CODE="${PROJECT_CODE:-da-cpu}"
QUEUE="${QUEUE:-batch}"

#-----------------------------------------------------------------------------
Expand Down Expand Up @@ -64,8 +64,8 @@ TEST1=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_C
LOG_FILE=consistency.log02
export DATA="${DATA_DIR}/test2"
export COMOUT=$DATA
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.lndincsoilnoahmp.sh)
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.gsi_lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.gsi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log03
export DATA="${DATA_DIR}/test3"
Expand All @@ -79,10 +79,16 @@ export COMOUT=$DATA
TEST4=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c48.noahmp.frac \
-o $LOG_FILE -e $LOG_FILE ./C48.noahmp.fracgrid.sh)

LOG_FILE=consistency.log05
export DATA="${DATA_DIR}/test5"
export COMOUT=$DATA
TEST5=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.jedi_lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.jedi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log
sbatch --nodes=1 -t 0:01:00 -A $PROJECT_CODE -J chgres_summary -o $LOG_FILE -e $LOG_FILE \
--open-mode=append -q $QUEUE -d\
afterok:$TEST1:$TEST2:$TEST3:$TEST4 << EOF
afterok:$TEST1:$TEST2:$TEST3:$TEST4:$TEST5 << EOF
#!/bin/bash
grep -a '<<<' ${LOG_FILE}* > summary.log
EOF
Expand Down
12 changes: 9 additions & 3 deletions reg_tests/global_cycle/driver.hercules.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ TEST1=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_C
LOG_FILE=consistency.log02
export DATA="${DATA_DIR}/test2"
export COMOUT=$DATA
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.lndincsoilnoahmp.sh)
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.gsi_lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.gsi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log03
export DATA="${DATA_DIR}/test3"
Expand All @@ -79,10 +79,16 @@ export COMOUT=$DATA
TEST4=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c48.noahmp.frac \
-o $LOG_FILE -e $LOG_FILE ./C48.noahmp.fracgrid.sh)

LOG_FILE=consistency.log05
export DATA="${DATA_DIR}/test5"
export COMOUT=$DATA
TEST5=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.jedi_lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.jedi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log
sbatch --nodes=1 -t 0:01:00 -A $PROJECT_CODE -J chgres_summary -o $LOG_FILE -e $LOG_FILE \
--open-mode=append -q $QUEUE -d\
afterok:$TEST1:$TEST2:$TEST3:$TEST4 << EOF
afterok:$TEST1:$TEST2:$TEST3:$TEST4:$TEST5 << EOF
#!/bin/bash
grep -a '<<<' ${LOG_FILE}* > summary.log
EOF
Expand Down
12 changes: 9 additions & 3 deletions reg_tests/global_cycle/driver.jet.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ TEST1=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_C
LOG_FILE=consistency.log02
export DATA="${DATA_DIR}/test2"
export COMOUT=$DATA
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.lndincsoilnoahmp \
--partition=xjet -o $LOG_FILE -e $LOG_FILE ./C192.lndincsoilnoahmp.sh)
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.gsi_lndincsoilnoahmp \
--partition=xjet -o $LOG_FILE -e $LOG_FILE ./C192.gsi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log03
export DATA="${DATA_DIR}/test3"
Expand All @@ -77,10 +77,16 @@ export COMOUT=$DATA
TEST4=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c48.noahmp.frac \
--partition=xjet -o $LOG_FILE -e $LOG_FILE ./C48.noahmp.fracgrid.sh)

LOG_FILE=consistency.log05
export DATA="${DATA_DIR}/test5"
export COMOUT=$DATA
TEST5=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.jedi_lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.jedi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log
sbatch --partition=xjet --nodes=1 -t 0:01:00 -A $PROJECT_CODE -J summary -o $LOG_FILE -e $LOG_FILE \
--open-mode=append -q $QUEUE -d\
afterok:$TEST1:$TEST2:$TEST3:$TEST4 << EOF
afterok:$TEST1:$TEST2:$TEST3:$TEST4:$TEST5 << EOF
#!/bin/bash
grep -a '<<<' ${LOG_FILE}* > ./summary.log
EOF
Expand Down
12 changes: 9 additions & 3 deletions reg_tests/global_cycle/driver.orion.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ TEST1=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_C
LOG_FILE=consistency.log02
export DATA="${DATA_DIR}/test2"
export COMOUT=$DATA
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.lndincsoilnoahmp.sh)
TEST2=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.gsi_lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.gsi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log03
export DATA="${DATA_DIR}/test3"
Expand All @@ -77,10 +77,16 @@ export COMOUT=$DATA
TEST4=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c48.noahmp.frac \
-o $LOG_FILE -e $LOG_FILE ./C48.noahmp.fracgrid.sh)

LOG_FILE=consistency.log05
export DATA="${DATA_DIR}/test5"
export COMOUT=$DATA
TEST5=$(sbatch --parsable --ntasks-per-node=6 --nodes=1 -t 0:05:00 -A $PROJECT_CODE -q $QUEUE -J c192.jedi_lndincsoilnoahmp \
-o $LOG_FILE -e $LOG_FILE ./C192.jedi_lndincsoilnoahmp.sh)

LOG_FILE=consistency.log
sbatch --nodes=1 -t 0:01:00 -A $PROJECT_CODE -J chgres_summary -o $LOG_FILE -e $LOG_FILE \
--open-mode=append -q $QUEUE -d\
afterok:$TEST1:$TEST2:$TEST3:$TEST4 << EOF
afterok:$TEST1:$TEST2:$TEST3:$TEST4:$TEST5 << EOF
#!/bin/bash
grep -a '<<<' ${LOG_FILE}* > summary.log
EOF
Expand Down
2 changes: 1 addition & 1 deletion reg_tests/global_cycle/driver.wcoss2.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ TEST1=$(qsub -V -o ${LOG_FILE}01 -e ${LOG_FILE}01 -q $QUEUE -A $PROJECT_CODE -l
export DATA="${DATA_DIR}/test2"
export COMOUT=$DATA
TEST2=$(qsub -V -o ${LOG_FILE}02 -e ${LOG_FILE}02 -q $QUEUE -A $PROJECT_CODE -l walltime=00:05:00 \
-N c192.lndincsoilnoahmp -l select=1:ncpus=12:mem=8GB $PWD/C192.lndincsoilnoahmp.sh)
-N c192.gsi_lndincsoilnoahmp -l select=1:ncpus=12:mem=8GB $PWD/C192.gsi_lndincsoilnoahmp.sh)

export DATA="${DATA_DIR}/test3"
export COMOUT=$DATA
Expand Down
Loading