Add capability to read soil increments on the cubed-sphere tiles and enhance soil ice adjustment due to soil temperature increments #894

yuanxue2870 · 2024-02-10T15:12:52Z

DESCRIPTION OF CHANGES:

add capability to read soil (i.e., both soil temp and soil moisture) increments from jedi-based cubed-sphere tiles directly
add capability to write out increments on the cubed-sphere grid from interpolating gsi-based soil increments on the Gaussian grid
revise calculate_landinc_mask to make it more stable
add noahmp-related parameters for soil ice adjustment after ingesting soil temp increments
separate gsi based interpolation routine from its original add-increment routine
combine jedi-based and gsi-based soil increments ingest and adjustment capability
revise current soil ice adjustment routine based on the analysis of a thorough synthetic DA experiments conducted separately
append _JEDI to the original DO_SNO_INC option for snow increment to be consistent with newly-added JEDI-based soil increment option of DO_SOI_INC_JEDI
add a namelist option for DO_SOI_INC_GSI and remote GSI_SOI_FILE option in the namelist
add a namelist option for lsoil_incr and set it to 3 as the default value
add a unit test (ftst_read_increments) to read jedi-based soil increments on the cubed-sphere grid. This unit test requires input data, these input data will be housed elsewhere, other than Github. George is coordinating with Kate to host the test data online
revise the unit test (ftst_land_increments) to ingest soil temperature increments and adjust soil ice content using newly-revised scheme
add a regression test (C192.jedi_lndincsoilnoahmp.sh) to ingest jedi-based soil increments and apply adjustment. This newly-added regression test requires the same input data from the unit test. The original regression test#2 was renamed from C192.lndincsoilnoahmp.sh to C192.gsi_lndincsoilnoahmp.sh

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

All my code edits should only affect global_cycle related unit tests and regression tests:

Compile branch on all Tier 1 machines using Intel. Done using e3a9149.
Compile branch on Hera using GNU. Done using e3a9149.
Compile branch in 'Debug' mode on WCOSS2. Done using e3a9149.
Run unit tests locally on any Tier 1 machine. Done on Hera using e3a9149.
Run relevant consistency tests locally on all Tier 1 machine. Done using e3a9149. global_cycle tests 1, 3, and 4 passed as expected. Test 2 failed as expected. Test 5 is new.

REFERENCES:

This PR incorporates all reviews/feedback from PR#871 (#871))

ISSUE:

Fixes #872.

NOTES:

Without the apply_land_da_adjustments_soil routine, C192.jedi_lndincsoilnoahmp.sh and C192.gsi_lndincsoilnoahmp.sh yields identical results. With the apply_land_da_adjustments_soil routine, C192.jedi_lndincsoilnoahmp.sh and C192.gsi_lndincsoilnoahmp.sh yields slightly different results on tile3 because GSI option checks nearby soil and no updates will be taking place for GSI grid with no soil nearby. However, JEDI option does not check nearby soil.
Baseline output are required to change for regression test#2 and regression test#5.

yuanxue2870 · 2024-02-12T14:30:20Z

Please re-review, @GeorgeGayno-NOAA and @ClaraDraper-NOAA, Thank you for your help!

…870/UFS_UTILS into feature/soil_ice_adjust

build_all.sh

reg_tests/global_cycle/driver.hera.sh

reg_tests/global_cycle/C192.jedi_lndincsoilnoahmp.sh

ush/global_cycle.sh

…ersion

GeorgeGayno-NOAA · 2024-02-22T14:09:59Z

I placed the input data - soil_xainc.00? - for one of your regression tests under the official test directory. You can now update global_cycle_driver.sh as follows:

--- a/ush/global_cycle_driver.sh
+++ b/ush/global_cycle_driver.sh
@@ -101,7 +101,7 @@ for n in $(seq 1 $ntiles); do
   fi

   if [[ "$DO_SOI_INC_JEDI" == ".true." ]] ; then
-        ln -fs $HOMEgfs/tests/global_cycle/data/soil_xainc.00$n $DATA/.
+        ln -fs $COMIN/soil_xainc.00$n $DATA/.
   fi
 done

GeorgeGayno-NOAA · 2024-02-22T14:56:23Z

@yuanxue2870 The latest merge to develop (#899) will cause some conflicts with your branch. I can help fix them.

yuanxue2870 · 2024-02-22T15:58:38Z

@yuanxue2870 The latest merge to develop (#899) will cause some conflicts with your branch. I can help fix them.

Thanks for the heads up, and thanks for your help in advance!

yuanxue2870 · 2024-02-22T16:03:40Z

I placed the input data - soil_xainc.00? - for one of your regression tests under the official test directory. You can now update global_cycle_driver.sh as follows:
--- a/ush/global_cycle_driver.sh
+++ b/ush/global_cycle_driver.sh
@@ -101,7 +101,7 @@ for n in $(seq 1 $ntiles); do
   fi

   if [[ "$DO_SOI_INC_JEDI" == ".true." ]] ; then
-        ln -fs $HOMEgfs/tests/global_cycle/data/soil_xainc.00$n $DATA/.
+        ln -fs $COMIN/soil_xainc.00$n $DATA/.
   fi
 done

Done. Thanks!

ClaraDraper-NOAA

My wifi cutout, and I thought I'd lost my review and started again - but now I think it's still there. Ignore this for now, and give me a minute to clean it up.

sorc/global_cycle.fd/cycle.f90

sorc/global_cycle.fd/read_write_data.f90

sorc/global_cycle.fd/cycle.f90

ClaraDraper-NOAA

I've had a look at all of it, except the apply_increments file, as there are too many changes for git to be helpful. I'll check it out now, and compare them.

So far, my main comments are:

This is a very large PR, which makes it very difficult to review.
I'm not clear that your "JEDI" soil increment files are actually from JEDI (as opposed to being increment files you created on the native model grid). If they're not from JEDI, we'll need to create some, and check that this code works with them. I can help with that.

ClaraDraper-NOAA · 2024-02-22T21:41:25Z

sorc/global_cycle.fd/read_write_data.f90

@@ -1512,6 +1577,22 @@ SUBROUTINE READ_DATA(LSOIL,LENSFC,DO_NSST,INC_FILE,IS_NOAHMP, &
 STCFCS = RESHAPE(DUMMY3D, (/LENSFC,LSOIL/))
 ENDIF

+ IF (PRESENT(SLCINC)) THEN


I'm 99% sure that the files created by JEDI use the variable name for the increment (not "*_inc").You can delete the SLCINC and STCINC options, and just use the STC and SLC options above (there's no special snow increment option, which makes me think I'm right).

If you have done this, and developed the tests using files you created yourself (for synthetic experiments), then I think we need to generate some actual JEDI files and use those instead. I can help with this.

Discussed this issue with Clara via email on 02/23/2024. For now, the soil_xainc.00$N files are created using the output from interpolated GSI increments. Will contact Mike to create some real-JEDI derived increments.

ClaraDraper-NOAA · 2024-02-22T21:42:48Z

sorc/lsm_routines.fd/noah.fd/set_soilveg_snippet.f90

@@ -85,6 +93,51 @@ subroutine set_soilveg(isot,ivet, maxsmc, bb, satpsi, iret)

  iret = 0

-end subroutine set_soilveg
+end subroutine set_soilveg_noah


@barlage Don't suppose there's a better way to do this (read them in from the same place the model does). Or are they very unlikely to change?

ush/global_cycle.sh

ClaraDraper-NOAA

comments on changes to land_increments.

Sorry for mutiple reviews - it's a big PR.

sorc/global_cycle.fd/land_increments.f90

ClaraDraper-NOAA · 2024-02-22T22:24:14Z

sorc/global_cycle.fd/land_increments.f90

          n_stc = 0
          n_slc = 0

          do i=1,lensfc
-          if (stc_updated(i) == 1 ) then
+            if (stc_updated(i) == 1 ) then ! soil-only location


I haven't gone through the logic here.

Hi Mike @barlage, Clara mentioned that she would like you to review this part of the code (i.e., consistency check). Thanks!!

ClaraDraper-NOAA · 2024-02-22T22:33:07Z

My wifi cutout, and I thought I'd lost my review and started again - but now I think it's still there. Ignore this for now, and give me a minute to clean it up.

I think I cleaned everything up. Thanks @yuanxue2870 for all your hard work on this. It's coming together!

ClaraDraper-NOAA · 2024-02-22T22:39:31Z

One more thought. Instead of using a single routine to interpolate (if needed), then add the increments - maybe it'd be better to have one routine for interpolating (if needed), then one for adding.

GeorgeGayno-NOAA · 2024-02-23T12:56:27Z

I've had a look at all of it, except the apply_increments file, as there are too many changes for git to be helpful. I'll check it out now, and compare them.

So far, my main comments are:

This is a very large PR, which makes it very difficult to review.

I'm not clear that your "JEDI" soil increment files are actually from JEDI (as opposed to being increment files you created on the native model grid). If they're not from JEDI, we'll need to create some, and check that this code works with them. I can help with that.

Feel free to break up this work into multiple pull requests.

reg_tests/global_cycle/driver.wcoss2.sh

GeorgeGayno-NOAA · 2024-04-05T20:42:56Z

Currently, awaiting real-JEDI generated soil increments files from Cory/Clara based on conversations with Mike on 03/07. Based on the email communications with Cory on 03/21, real-JEDI generated soil increments will be provided on the C192 grid. While I am on hold, I am taking this PR offline and once I finish testing with the new increment files. I will put the PR back online and ping all reviewers to review. Thank you!

Thanks Cory for providing me with the real (mimicked) JEDI soil increment files. Now all tests are done. Please re-review: @GeorgeGayno-NOAA, @ClaraDraper-NOAA, @barlage.

@GeorgeGayno-NOAA: the input files used in the unit test ftst_read_increments and regression test#5 are changed. Would you please replace the test data files of soil_xainc.00N with soil_sfcincr_jedi.00N files located within /scratch2/NCEPDEV/stmp1/Yuan.Xue/pull_request/ on Hera? Thank you!

@KateFriedman-NOAA - you had hosted the soil_xainc.00N files here: https://ftp.emc.ncep.noaa.gov/static_files/public/UFS/ufs_utils/unit_tests/global_cycle/

Could you please replace them with the soil_sfcincr_jedi.00N files?

KateFriedman-NOAA · 2024-04-08T16:30:28Z

Could you please replace them with the soil_sfcincr_jedi.00N files?

@GeorgeGayno-NOAA Done:

[emc.glopara@vm-cprk-emcrzdm03 global_cycle]$ pwd
/home/ftp/emc/static_files/public/UFS/ufs_utils/unit_tests/global_cycle
[emc.glopara@vm-cprk-emcrzdm03 global_cycle]$ ll
total 10464
-rw-r--r--. 1 emc.glopara emc 1776316 Apr  1 17:05 soil_sfcincr_jedi.001
-rw-r--r--. 1 emc.glopara emc 1776316 Apr  1 17:05 soil_sfcincr_jedi.002
-rw-r--r--. 1 emc.glopara emc 1776316 Apr  1 17:05 soil_sfcincr_jedi.003
-rw-r--r--. 1 emc.glopara emc 1776316 Apr  1 17:06 soil_sfcincr_jedi.004
-rw-r--r--. 1 emc.glopara emc 1776316 Apr  1 17:06 soil_sfcincr_jedi.005
-rw-r--r--. 1 emc.glopara emc 1776316 Apr  1 17:06 soil_sfcincr_jedi.006

GeorgeGayno-NOAA · 2024-04-09T15:22:02Z

@yuanxue2870 I was able to successfully run the unit tests with the new files Kate hosted. I had to make these modifications:

--- a/tests/global_cycle/CMakeLists.txt
+++ b/tests/global_cycle/CMakeLists.txt
@@ -5,12 +5,12 @@

 set(CYCLE_URL "https://ftp.emc.ncep.noaa.gov/static_files/public/UFS/ufs_utils/unit_tests/global_cycle")

-set(FILE1 "soil_xainc.001")
-set(FILE2 "soil_xainc.002")
-set(FILE3 "soil_xainc.003")
-set(FILE4 "soil_xainc.004")
-set(FILE5 "soil_xainc.005")
-set(FILE6 "soil_xainc.006")
+set(FILE1 "soil_sfcincr_jedi.001")
+set(FILE2 "soil_sfcincr_jedi.002")
+set(FILE3 "soil_sfcincr_jedi.003")
+set(FILE4 "soil_sfcincr_jedi.004")
+set(FILE5 "soil_sfcincr_jedi.005")
+set(FILE6 "soil_sfcincr_jedi.006")

--- a/sorc/global_cycle.fd/cycle.f90
+++ b/sorc/global_cycle.fd/cycle.f90
@@ -782,7 +782,7 @@ ENDIF
        !--------------------------------------------------------------------------------
        ! make sure incr. files exist
         WRITE(RANKCH, '(I3.3)') (MYRANK+1)
-        JEDI_SOI_FILE = "soil_xainc." //  RANKCH
+        JEDI_SOI_FILE = "soil_sfcincr_jedi." //  RANKCH

         INQUIRE(FILE=trim(JEDI_SOI_FILE), EXIST=file_exists)

--- a/sorc/global_cycle.fd/read_write_data.f90
+++ b/sorc/global_cycle.fd/read_write_data.f90
@@ -1149,7 +1149,7 @@ MODULE READ_WRITE_DATA
  IF ((INC_FILE) .and. (DO_SNO_INC_JEDI)) THEN
         FNBGSI = "./snow_xainc." // RANKCH
  ELSEIF ((INC_FILE) .and. (DO_SOI_INC_JEDI)) THEN
-        FNBGSI = "./soil_xainc." // RANKCH
+        FNBGSI = "./soil_sfcincr_jedi." // RANKCH
  ELSE
         FNBGSI = "./fnbgsi." // RANKCH
  ENDIF

ush/global_cycle_driver.sh

yuanxue2870 · 2024-04-09T16:54:44Z

@yuanxue2870 I was able to successfully run the unit tests with the new files Kate hosted. I had to make these modifications:

--- a/tests/global_cycle/CMakeLists.txt
+++ b/tests/global_cycle/CMakeLists.txt
@@ -5,12 +5,12 @@

 set(CYCLE_URL "https://ftp.emc.ncep.noaa.gov/static_files/public/UFS/ufs_utils/unit_tests/global_cycle")

-set(FILE1 "soil_xainc.001")
-set(FILE2 "soil_xainc.002")
-set(FILE3 "soil_xainc.003")
-set(FILE4 "soil_xainc.004")
-set(FILE5 "soil_xainc.005")
-set(FILE6 "soil_xainc.006")
+set(FILE1 "soil_sfcincr_jedi.001")
+set(FILE2 "soil_sfcincr_jedi.002")
+set(FILE3 "soil_sfcincr_jedi.003")
+set(FILE4 "soil_sfcincr_jedi.004")
+set(FILE5 "soil_sfcincr_jedi.005")
+set(FILE6 "soil_sfcincr_jedi.006")

--- a/sorc/global_cycle.fd/cycle.f90
+++ b/sorc/global_cycle.fd/cycle.f90
@@ -782,7 +782,7 @@ ENDIF
        !--------------------------------------------------------------------------------
        ! make sure incr. files exist
         WRITE(RANKCH, '(I3.3)') (MYRANK+1)
-        JEDI_SOI_FILE = "soil_xainc." //  RANKCH
+        JEDI_SOI_FILE = "soil_sfcincr_jedi." //  RANKCH

         INQUIRE(FILE=trim(JEDI_SOI_FILE), EXIST=file_exists)

--- a/sorc/global_cycle.fd/read_write_data.f90
+++ b/sorc/global_cycle.fd/read_write_data.f90
@@ -1149,7 +1149,7 @@ MODULE READ_WRITE_DATA
  IF ((INC_FILE) .and. (DO_SNO_INC_JEDI)) THEN
         FNBGSI = "./snow_xainc." // RANKCH
  ELSEIF ((INC_FILE) .and. (DO_SOI_INC_JEDI)) THEN
-        FNBGSI = "./soil_xainc." // RANKCH
+        FNBGSI = "./soil_sfcincr_jedi." // RANKCH
  ELSE
         FNBGSI = "./fnbgsi." // RANKCH
  ENDIF

Thanks. As Kate helps us hosting the increment files, I have now made edits to the unit test file reader and the ush/global_cycle_driver file to link directly from the public host. Your solution is also viable, but if we modify the filename in the main read_write.f90 as such, it will not be consistent with snow JEDI increment files then. I guess one of the main purposes of this PR is to make soil and snow related names/routines consistent. Therefore, I would like to retain the filename as "soil_xainc" since it is consistent with "snow_xainc". Please feel free to let me know if there are any further concerns. I am happy to adjust if needed.

GeorgeGayno-NOAA · 2024-04-09T17:58:16Z

@yuanxue2870 I was able to successfully run the unit tests with the new files Kate hosted. I had to make these modifications:
--- a/tests/global_cycle/CMakeLists.txt
+++ b/tests/global_cycle/CMakeLists.txt
@@ -5,12 +5,12 @@

 set(CYCLE_URL "https://ftp.emc.ncep.noaa.gov/static_files/public/UFS/ufs_utils/unit_tests/global_cycle")

-set(FILE1 "soil_xainc.001")
-set(FILE2 "soil_xainc.002")
-set(FILE3 "soil_xainc.003")
-set(FILE4 "soil_xainc.004")
-set(FILE5 "soil_xainc.005")
-set(FILE6 "soil_xainc.006")
+set(FILE1 "soil_sfcincr_jedi.001")
+set(FILE2 "soil_sfcincr_jedi.002")
+set(FILE3 "soil_sfcincr_jedi.003")
+set(FILE4 "soil_sfcincr_jedi.004")
+set(FILE5 "soil_sfcincr_jedi.005")
+set(FILE6 "soil_sfcincr_jedi.006")
--- a/sorc/global_cycle.fd/cycle.f90
+++ b/sorc/global_cycle.fd/cycle.f90
@@ -782,7 +782,7 @@ ENDIF
        !--------------------------------------------------------------------------------
        ! make sure incr. files exist
         WRITE(RANKCH, '(I3.3)') (MYRANK+1)
-        JEDI_SOI_FILE = "soil_xainc." //  RANKCH
+        JEDI_SOI_FILE = "soil_sfcincr_jedi." //  RANKCH

         INQUIRE(FILE=trim(JEDI_SOI_FILE), EXIST=file_exists)
--- a/sorc/global_cycle.fd/read_write_data.f90
+++ b/sorc/global_cycle.fd/read_write_data.f90
@@ -1149,7 +1149,7 @@ MODULE READ_WRITE_DATA
  IF ((INC_FILE) .and. (DO_SNO_INC_JEDI)) THEN
         FNBGSI = "./snow_xainc." // RANKCH
  ELSEIF ((INC_FILE) .and. (DO_SOI_INC_JEDI)) THEN
-        FNBGSI = "./soil_xainc." // RANKCH
+        FNBGSI = "./soil_sfcincr_jedi." // RANKCH
  ELSE
         FNBGSI = "./fnbgsi." // RANKCH
  ENDIF
Thanks. As Kate helps us hosting the increment files, I have now made edits to the unit test file reader and the ush/global_cycle_driver file to link directly from the public host. Your solution is also viable, but if we modify the filename in the main read_write.f90 as such, it will not be consistent with snow JEDI increment files then. I guess one of the main purposes of this PR is to make soil and snow related names/routines consistent. Therefore, I would like to retain the filename as "soil_xainc" since it is consistent with "snow_xainc". Please feel free to let me know if there are any further concerns. I am happy to adjust if needed.

Your changes at 28a8cef are fine.

GeorgeGayno-NOAA · 2024-04-17T18:50:32Z

ush/global_cycle.sh

@@ -263,7 +264,9 @@ use_ufo=${use_ufo:-.true.}
 DONST=${DONST:-"NO"}
 DO_SFCCYCLE=${DO_SFCCYCLE:-.true.}
 DO_LNDINC=${DO_LNDINC:-.false.}


DO_SOI_INC_GSI is not defined in the prolog.

Hi George, thanks for the question. What do you mean by "prolog"? DO_SOI_INC_GSI along with other two options were defined in the ush/global_cycle.sh from Lines 267-269:

267 DO_SOI_INC_GSI=${DO_SOI_INC_GSI:-.false.}
268 DO_SNO_INC_JEDI=${DO_SNO_INC_JEDI:-.false.}
269 DO_SOI_INC_JEDI=${DO_SOI_INC_JEDI:-.false.}

Define it after line 144.

Thanks! Done.

GeorgeGayno-NOAA · 2024-04-18T19:39:29Z

sorc/global_cycle.fd/read_write_data.f90

@@ -472,6 +482,47 @@ subroutine write_data(lensfc,idim,jdim,lsoil, &
   call remove_checksum(ncid, id_var)
 endif


Since you are writing a new file - gaussian_interp.* - you could have created a new write routine to do this. Just a comment. You don't need to do this.

GeorgeGayno-NOAA · 2024-04-19T12:53:11Z

@ClaraDraper-NOAA and @barlage - I would like to merge this. Do you have any further comments?

@yuanxue2870 - please merge the latest updates from 'develop' to your branch.

GeorgeGayno-NOAA · 2024-04-19T14:51:34Z

@yuanxue2870 - I will need updated baseline files for regression tests 2 and 5. I am currently using:

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.gsi_lndincsoilnoahmp.1234
/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.jedi_lndincsoilnoahmp.1234

yuanxue2870 · 2024-04-19T15:37:30Z

@ClaraDraper-NOAA and @barlage - I would like to merge this. Do you have any further comments?

@yuanxue2870 - please merge the latest updates from 'develop' to your branch.

Done. Merged the latest updates from develop now.

yuanxue2870 · 2024-04-19T15:53:19Z

@yuanxue2870 - I will need updated baseline files for regression tests 2 and 5. I am currently using:

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.gsi_lndincsoilnoahmp.1234

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.jedi_lndincsoilnoahmp.1234

My regression tests output are located on Hera at /scratch2/NCEPDEV/stmp1/Yuan.Xue/reg-tests/global-cycle/test2 for c192.gsi_lndinc and at /scratch2/NCEPDEV/stmp1/Yuan.Xue/reg-tests/global-cycle/test5 for c192.jedi_lndinc, respectively.

GeorgeGayno-NOAA · 2024-04-19T17:51:38Z

@yuanxue2870 - I will need updated baseline files for regression tests 2 and 5. I am currently using:

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.gsi_lndincsoilnoahmp.1234

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.jedi_lndincsoilnoahmp.1234

My regression tests output are located on Hera at /scratch2/NCEPDEV/stmp1/Yuan.Xue/reg-tests/global-cycle/test2 for c192.gsi_lndinc and at /scratch2/NCEPDEV/stmp1/Yuan.Xue/reg-tests/global-cycle/test5 for c192.jedi_lndinc, respectively.

For test2, the 'gaussian_interp.00?' files are outputs, correct? If so, the regression test should compare them to the baseline. And the regression test script logic will need to be updated.

yuanxue2870 · 2024-04-19T18:11:18Z

@yuanxue2870 - I will need updated baseline files for regression tests 2 and 5. I am currently using:

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.gsi_lndincsoilnoahmp.1234

/scratch1/NCEPDEV/nems/role.ufsutils/ufs_utils/reg_tests/global_cycle/baseline_data/c192.jedi_lndincsoilnoahmp.1234

My regression tests output are located on Hera at /scratch2/NCEPDEV/stmp1/Yuan.Xue/reg-tests/global-cycle/test2 for c192.gsi_lndinc and at /scratch2/NCEPDEV/stmp1/Yuan.Xue/reg-tests/global-cycle/test5 for c192.jedi_lndinc, respectively.

For test2, the 'gaussian_interp.00?' files are outputs, correct? If so, the regression test should compare them to the baseline. And the regression test script logic will need to be updated.

Added. Done.

ClaraDraper-NOAA

I had a quick look through, and my comments have been addressed. I haven't done a very in depth review though.

Well done @yuanxue2870

reg_tests/global_cycle/driver.hera.sh

GeorgeGayno-NOAA · 2024-05-06T20:59:46Z

@yuanxue2870 - looks good. Will merge.

yuanxue2870 and others added 7 commits February 7, 2024 20:21

clean up & reorganize based on reviews

5c763f2

Delete unit test data/ from Github

f65d8fa

Delete unit test data

db18a1d

Delete unit test data

f709f7c

Delete unit test data

f6c9038

Delete unit test data

e731a85

Delete unit test data

a8daad2

yuanxue2870 mentioned this pull request Feb 10, 2024

Add capability to read soil increments on the cubed-sphere tiles and enhance soil ice adjustment due to soil temperature increments #872

Closed

GeorgeGayno-NOAA self-requested a review February 12, 2024 13:07

yuanxue2870 marked this pull request as ready for review February 12, 2024 14:34

yuanxue2870 added 2 commits February 14, 2024 18:26

obtain unit test data from server with updated unit test

0bacd5a

Merge branch 'feature/soil_ice_adjust' of https://github.com/yuanxue2…

84b075e

…870/UFS_UTILS into feature/soil_ice_adjust

GeorgeGayno-NOAA reviewed Feb 15, 2024

View reviewed changes

build_all.sh Outdated Show resolved Hide resolved

GeorgeGayno-NOAA reviewed Feb 15, 2024

View reviewed changes

reg_tests/global_cycle/driver.hera.sh Show resolved Hide resolved

GeorgeGayno-NOAA reviewed Feb 15, 2024

View reviewed changes

reg_tests/global_cycle/C192.jedi_lndincsoilnoahmp.sh Show resolved Hide resolved

GeorgeGayno-NOAA reviewed Feb 15, 2024

View reviewed changes

ush/global_cycle.sh Show resolved Hide resolved

updated driver scripts and revert build and mpiexec back to develop v…

89ae1fe

…ersion

updated directories for baseline and unit test data

a42b310

ClaraDraper-NOAA reviewed Feb 22, 2024

View reviewed changes

ClaraDraper-NOAA suggested changes Feb 22, 2024

View reviewed changes

GeorgeGayno-NOAA reviewed Feb 23, 2024

View reviewed changes

reg_tests/global_cycle/driver.wcoss2.sh Outdated Show resolved Hide resolved

GeorgeGayno-NOAA requested review from barlage and removed request for ClaraDraper-NOAA April 5, 2024 20:34

GeorgeGayno-NOAA reviewed Apr 9, 2024

View reviewed changes

ush/global_cycle_driver.sh Outdated Show resolved Hide resolved

edits to link unit test files from public host

28a8cef

yuanxue2870 requested review from ClaraDraper-NOAA and GeorgeGayno-NOAA April 9, 2024 16:58

GeorgeGayno-NOAA reviewed Apr 17, 2024

View reviewed changes

yuanxue2870 and others added 2 commits April 17, 2024 15:15

Merge branch 'ufs-community:develop' into feature/soil_ice_adjust

98b3c19

add options in the prolog

529e7e2

GeorgeGayno-NOAA reviewed Apr 18, 2024

View reviewed changes

Merge branch 'ufs-community:develop' into feature/soil_ice_adjust

d04da42

add gaussian_interp output to nccmp with baseline

e3a9149

ClaraDraper-NOAA approved these changes May 2, 2024

View reviewed changes

reg_tests/global_cycle/driver.hera.sh Outdated Show resolved Hide resolved

yuanxue2870 and others added 2 commits May 2, 2024 13:31

Merge branch 'ufs-community:develop' into feature/soil_ice_adjust

afdd2a9

revert to defaulted account name

1588668

GeorgeGayno-NOAA self-requested a review May 6, 2024 20:59

GeorgeGayno-NOAA approved these changes May 6, 2024

View reviewed changes

GeorgeGayno-NOAA merged commit e0cfc4b into ufs-community:develop May 7, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add capability to read soil increments on the cubed-sphere tiles and enhance soil ice adjustment due to soil temperature increments #894

Add capability to read soil increments on the cubed-sphere tiles and enhance soil ice adjustment due to soil temperature increments #894

yuanxue2870 commented Feb 10, 2024 •

edited by GeorgeGayno-NOAA

Loading

yuanxue2870 commented Feb 12, 2024

GeorgeGayno-NOAA commented Feb 22, 2024

GeorgeGayno-NOAA commented Feb 22, 2024

yuanxue2870 commented Feb 22, 2024 •

edited

Loading

yuanxue2870 commented Feb 22, 2024

ClaraDraper-NOAA left a comment

ClaraDraper-NOAA left a comment

ClaraDraper-NOAA Feb 22, 2024

yuanxue2870 Feb 24, 2024

ClaraDraper-NOAA Feb 22, 2024

ClaraDraper-NOAA left a comment

ClaraDraper-NOAA Feb 22, 2024

yuanxue2870 Mar 5, 2024

ClaraDraper-NOAA commented Feb 22, 2024

ClaraDraper-NOAA commented Feb 22, 2024

GeorgeGayno-NOAA commented Feb 23, 2024

GeorgeGayno-NOAA commented Apr 5, 2024

KateFriedman-NOAA commented Apr 8, 2024

GeorgeGayno-NOAA commented Apr 9, 2024

yuanxue2870 commented Apr 9, 2024

GeorgeGayno-NOAA commented Apr 9, 2024

GeorgeGayno-NOAA Apr 17, 2024

yuanxue2870 Apr 17, 2024

GeorgeGayno-NOAA Apr 17, 2024

yuanxue2870 Apr 17, 2024

GeorgeGayno-NOAA Apr 18, 2024

GeorgeGayno-NOAA commented Apr 19, 2024

GeorgeGayno-NOAA commented Apr 19, 2024

yuanxue2870 commented Apr 19, 2024

yuanxue2870 commented Apr 19, 2024

GeorgeGayno-NOAA commented Apr 19, 2024

yuanxue2870 commented Apr 19, 2024

ClaraDraper-NOAA left a comment

GeorgeGayno-NOAA commented May 6, 2024

		@@ -472,6 +482,47 @@ subroutine write_data(lensfc,idim,jdim,lsoil, &
		call remove_checksum(ncid, id_var)
		endif

Add capability to read soil increments on the cubed-sphere tiles and enhance soil ice adjustment due to soil temperature increments #894

Add capability to read soil increments on the cubed-sphere tiles and enhance soil ice adjustment due to soil temperature increments #894

Conversation

yuanxue2870 commented Feb 10, 2024 • edited by GeorgeGayno-NOAA Loading

DESCRIPTION OF CHANGES:

TESTS CONDUCTED:

REFERENCES:

ISSUE:

NOTES:

yuanxue2870 commented Feb 12, 2024

GeorgeGayno-NOAA commented Feb 22, 2024

GeorgeGayno-NOAA commented Feb 22, 2024

yuanxue2870 commented Feb 22, 2024 • edited Loading

yuanxue2870 commented Feb 22, 2024

ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClaraDraper-NOAA commented Feb 22, 2024

ClaraDraper-NOAA commented Feb 22, 2024

GeorgeGayno-NOAA commented Feb 23, 2024

GeorgeGayno-NOAA commented Apr 5, 2024

KateFriedman-NOAA commented Apr 8, 2024

GeorgeGayno-NOAA commented Apr 9, 2024

yuanxue2870 commented Apr 9, 2024

GeorgeGayno-NOAA commented Apr 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GeorgeGayno-NOAA commented Apr 19, 2024

GeorgeGayno-NOAA commented Apr 19, 2024

yuanxue2870 commented Apr 19, 2024

yuanxue2870 commented Apr 19, 2024

GeorgeGayno-NOAA commented Apr 19, 2024

yuanxue2870 commented Apr 19, 2024

ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

GeorgeGayno-NOAA commented May 6, 2024

yuanxue2870 commented Feb 10, 2024 •

edited by GeorgeGayno-NOAA

Loading

yuanxue2870 commented Feb 22, 2024 •

edited

Loading