fix(link): Do not convert link href
to number or boolean
#5391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Link
href
attribute doesn't have parseHTML provided, so TipTap uses a default implementation that converts strings to numbers/booleans. This leads to crashes in cases like:Render function assumes href is
string | null
.Implementation Approach
Provide a custom
parseHTML
implementation.Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues
#4929