fix(link): Do not convert link href to number or boolean (#5391)

ueberdosis · Aug 11, 2024 · 08b4319 · 08b4319
1 parent 84febb2
commit 08b4319
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/link-href-parsing-fix.md b/.changeset/link-href-parsing-fix.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/extension-link": fix
+---
+
+Fixes a bug where link `href` was converted to number or boolean during HTML parsing, leading to a crash in rendering.
diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
@@ -164,6 +164,9 @@ export const Link = Mark.create<LinkOptions>({
     return {
       href: {
         default: null,
+        parseHTML(element) {
+          return element.getAttribute('href')
+        },
       },
       target: {
         default: this.options.HTMLAttributes.target,
@@ -187,7 +190,7 @@ export const Link = Mark.create<LinkOptions>({
         if (!href || !isAllowedUri(href)) {
           return false
         }
-        return { href }
+        return null
       },
     }]
   },