-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add content to pasted nodes #4212
feat: add content to pasted nodes #4212
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@svenadlung you have something to point out here?
bcaef5c
to
7e7ae19
Compare
🦋 Changeset detectedLatest commit: b41fe4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Please describe your changes
The
nodePasteRule
exposed by TipTap does not support nested content. This makes it possible to specify the content based on the nodes attributes.How did you accomplish your changes
Added an optional parameter similar to
getAttributes
that allows for a typeJSONContent[]
or a function returningJSONContent[]
to be specifiedHow have you tested your changes
Manually. We have reimplemented the
nodePasteRule
in our own codebase for this exact purposeHow can we verify your changes
Create a node with a paste rule and some content specified. You should see the content as a child when created in the editor
Remarks
N/A
Checklist
Related issues
N/A